Skip to content

Fix: Allow empty kms_key_id to preserve backwards compatibility (AWS Launch Template) #44708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Allow empty kms_key_id to preserve backwards compatibility (AWS Launch Template) #44708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions internal/verify/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,13 +313,19 @@ func IsIPv4CIDRBlockOrIPv6CIDRBlock(ipv4Validator, ipv6Validator schema.SchemaVa
// ref: https://docs.aws.amazon.com/kms/latest/developerguide/concepts.html#key-id
// ref: https://docs.aws.amazon.com/kms/latest/APIReference/API_Encrypt.html#KMS-Encrypt-request-KeyId
func ValidKMSKeyID(v any, k string) (ws []string, errors []error) {
value := v.(string)
if len(value) < 1 {
errors = append(errors, fmt.Errorf("%q cannot be shorter than 1 character", k))
} else if len(value) > 2048 {
value, ok := v.(string)
if !ok {
errors = append(errors, fmt.Errorf("expected type of %s to be string", k))
return ws, errors
}
// Allow empty string for backward compatibility
if value == "" {
return ws, errors
}
if len(value) > 2048 {
errors = append(errors, fmt.Errorf("%q cannot be longer than 2048 characters", k))
}
return
return ws, errors
}

func ValidLaunchTemplateID(v any, k string) (ws []string, errors []error) {
Expand Down
Loading