Skip to content

Feature/aws workspaces pool #44747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feature/aws workspaces pool #44747

wants to merge 9 commits into from
+1,434 −0

Conversation

@hanoj-budime
Copy link

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Relations

Closes #38823

References

#42678
https://docs.aws.amazon.com/workspaces/latest/api/API_WorkspacesPool.html
https://docs.aws.amazon.com/workspaces/latest/api/API_CreateWorkspacesPool.html

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@hanoj-budime hanoj-budime requested a review from a team as a code owner October 21, 2025 12:24
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Contributor

⚠️ Our automation has detected the following potential issues with your pull request

❌ Changelog Entry Required (Click to expand)

The proposed change requires a changelog entry. Please see the Changelog Process section of the contributing guide for information on the changelog generation process.

Tip: This check is not triggered for draft pull requests, since the pull request number is not known until the pull request is opened and is required to create a changelog entry. Opening a pull request first as a draft, adding the requisite changelog entry file, and then marking the pull request as ready for review will prevent future warnings.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/workspaces Issues and PRs that pertain to the workspaces service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Oct 21, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 22, 2025
hanoj-budime and others added 5 commits October 23, 2025 08:27
@hanoj-budime
✨ aws_workspaces_pool
d561650
@hanoj-budime
Merge pull request #2 from hanoj-budime/feature/aws_workspaces_pool_fmt
982d99e 
✨ aws_workspaces_pool
@hanoj-budime
✨ aws_workspaces_pool
7ff9f57
@hanoj-budime
Fix: Markdown linting errors in Workspaces Pool docs
99e2d70 
Resolves MD047 (single trailing newline) and MD012 (no multiple blanks) in:
- website/docs/d/workspaces_pool.html.markdown
- website/docs/r/workspaces_pool.html.markdown
@hanoj-budime
docs/workspaces_pool: Correctly list argument as Optional
d7d100d 
Updates the documentation for the `aws_workspaces_pool` resource to move an argument from the 'Required Arguments' section to the 'Optional Arguments' section in `website/docs/r/workspaces_pool.html.markdown`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. new-data-source Introduces a new data source. new-resource Introduces a new resource. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[New Resource]: AWS Workspace pool

2 participants

@hanoj-budime @justinretzolk