Skip to content

VAULT-48712: update HTTP mode config to use VAULT_ADDR header instead of query param in README - #131

Merged
Himnish-Nadiminti merged 5 commits into
mainfrom
himnish-nadiminti/fix-ssrf-vault-addr-query-param
Aug 20, 2026
Merged

VAULT-48712: update HTTP mode config to use VAULT_ADDR header instead of query param in README#131
Himnish-Nadiminti merged 5 commits into
mainfrom
himnish-nadiminti/fix-ssrf-vault-addr-query-param

Conversation

@Himnish-Nadiminti

@Himnish-Nadiminti Himnish-Nadiminti commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Screenshot of mcp.json
image
The list mount working
image

Screenshot of /.gemin/.env
image
/mcp-list working
image

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

If you have any questions, please contact your direct supervisor, GRC (#team-grc), or the PCI working group (#proj-pci-reboot). You can also find more information at PCI Compliance.

@Himnish-Nadiminti
Himnish-Nadiminti marked this pull request as ready for review August 19, 2026 04:23
@Himnish-Nadiminti
Himnish-Nadiminti requested a review from a team as a code owner August 19, 2026 04:23
@stuti-sr

Copy link
Copy Markdown
Contributor

Please provide PR description and screenshot of mcp.json for vscode and gemini extension.

Comment thread README.md Outdated
Co-authored-by: sachin-chand01 <sachin.chand@hashicorp.com>

@vivekpandeyHashi vivekpandeyHashi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sachin-chand01 sachin-chand01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gautambaghel gautambaghel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuti-sr stuti-sr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Himnish-Nadiminti
Himnish-Nadiminti merged commit 59f5117 into main Aug 20, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants