Skip to content

UI: remove mountable auth #30825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 59 commits into from
Closed

Conversation

drivera258
Copy link
Contributor

@drivera258 drivera258 commented Jun 3, 2025

Description

What does this PR do?

(to be updated and merged into main after #30712 goes in - post branch cut)

Follow on to #30712 - after adding a centralized file to get engine & auth method data 'all-engines-metadata.ts'
we're making an effort to replace/remove older files that have the same data or similar to use this new file instead

  • Removes mountable-auth-methods.js
  • updates all previous usage with new metadata file / helper that queries that metadata file as needed

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@drivera258 drivera258 changed the title UI/vault 36733/remove mountable auth UI: remove mountable auth Jun 3, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 3, 2025
Copy link

github-actions bot commented Jun 3, 2025

CI Results:
All Go tests succeeded! ✅

@drivera258 drivera258 changed the base branch from main to ui/VAULT-34931/add-plugin-version June 4, 2025 16:15
@drivera258 drivera258 changed the base branch from ui/VAULT-34931/add-plugin-version to main June 4, 2025 16:15
bosouza and others added 25 commits June 4, 2025 14:09
* add new fields to sample response

* skip instead of sleep
…nent (#30781)

* [UI] added missing tests for `@layout` argument of `editType=radio` (#36594)

* [UI] added missing tests for `@name` argument of `editType=radio` (#36594)

* [UI] added missing tests for `@value` argument of `possibleValue` in `editType=radio`

* [UI] added missing tests for `@editDisabled` option in `editType=radio` (#36594)

* [UI] added missing tests for `@name` argument of `editType=checkboxList` (#36594)

* [UI] added missing tests for `@value` argument of `possibleValue` in `editType=checkboxList` (#36594)

* [UI] added missing tests for `@id` argument and `name` attribute of `editType=select` (#36594)

* [UI] added missing tests for `name`, `placeholder`, `autocomplete`, `spellcheck` attributes of `editType=password` (#36594)

* [UI] added back test removed in PR 30768 (#30781)

context: https://hashicorp.slack.com/archives/CA64C81U5/p1748465244375689
* show most recent months first in option list

* update test
* added 1.19.5 changelog records to main

* added LTS notice

* added changelog record for other minor releases

* updated to use the correct record for each change log entry

---------

Co-authored-by: lursu <[email protected]>
* Update vault-plugin-database-redis-elasticache to v0.7.0

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
* Update vault-plugin-database-elasticsearch to v0.18.0

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
…otas (#30763)

* add API docs

* add new fields to sample response
* core metrics changes

* removing internal repo references

* CE changes from Vault Operator Import

* removing unrelated code

* removing unnecessary go mod updates

* updating go mod
* fix typos, check for supported auth method and render direct link in display view too

* add namespace

* linebreak

* add tests
* Update vault-plugin-database-redis to v0.6.0

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
…t type (#30805)

* Fixes issue where backup tab was selected if backups include default type

* fix enterprise empty state assertion
…p_import_rotation=true (#30687)

* upgrade known issue documentation with fix version for roles with skip_import_rotation=true

* Update website/content/partials/known-issues/database-skip-static-role-rotation.mdx

Co-authored-by: Sarah Chavis <[email protected]>

* Update website/content/partials/known-issues/database-skip-static-role-rotation.mdx

* Update website/content/partials/known-issues/database-skip-static-role-rotation.mdx

---------

Co-authored-by: Sarah Chavis <[email protected]>
…30813)

Fix a potential race where we might attempt to update the auth before
we've initially configured it. Also, rather than update it on all nodes
we now choose a node in the cluster at random.

Signed-off-by: Ryan Cragun <[email protected]>
* Update vault-plugin-secrets-ad to v0.21.0

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
* Update vault-plugin-auth-alicloud to v0.21.0

* Add changelog

---------

Co-authored-by: hc-github-team-secure-vault-ecosystem <[email protected]>
@drivera258 drivera258 force-pushed the ui/VAULT-36733/remove-mountable-auth branch from ec3f199 to afc0642 Compare June 4, 2025 18:10
@drivera258 drivera258 changed the base branch from main to ui/VAULT-34931/add-plugin-version June 4, 2025 18:10
@drivera258 drivera258 changed the base branch from ui/VAULT-34931/add-plugin-version to main June 4, 2025 18:11
@drivera258 drivera258 closed this Jun 4, 2025
@drivera258 drivera258 deleted the ui/VAULT-36733/remove-mountable-auth branch June 4, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.