Skip to content

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Aug 22, 2025

Adding a known issue with event subscriptions in Vault 1.19 and 1.20 ENT.

Copy link

github-actions bot commented Aug 22, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Fri Sep 5 23:56:24 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Fri Sep 5 23:48:07 UTC 2025

Copy link

github-actions bot commented Aug 22, 2025

Broken Link Checker

No broken links found! 🎉

@yhyakuna yhyakuna added the Vault Content update for Vault product docs label Aug 28, 2025
@tvoran tvoran marked this pull request as ready for review August 28, 2025 18:46
@tvoran tvoran requested a review from a team as a code owner August 28, 2025 18:46
@schavis
Copy link
Contributor

schavis commented Sep 4, 2025

@tvoran The update text looks good. Please also add an entry to the summary tables for 1.19 and 1.20 under /content/vault/global/partials/important-changes/summary-tables

Copy link
Contributor

@schavis schavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing summary table updates

@github-actions github-actions bot added the Vault IC Higher priority Vault content PR. Update relates to an important changes announcement. label Sep 5, 2025
@tvoran tvoran requested a review from schavis September 5, 2025 23:36
Comment on lines +477 to +480
Users may miss events if two or more event clients subscribe to the same
performance standby node in a cluster, and each client specifies the same
namespace and event type filters. If one client disconnects, the other(s) will
no longer receive events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users may miss events if two or more event clients subscribe to the same
performance standby node in a cluster, and each client specifies the same
namespace and event type filters. If one client disconnects, the other(s) will
no longer receive events.
Users may miss events when multiple clients subscribe to the same performance
standby node in a cluster with the same namespace and event type filters because
one client disconnecting unsubscribes the remaining clients who no longer
receive events.

Style correction: write in active voice

Comment on lines +484 to +486
If there are multiple event subscribers with the same namespace and event type
filters, spread them out among the nodes of the Vault cluster, or only subscribe
to events on the active node of the cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If there are multiple event subscribers with the same namespace and event type
filters, spread them out among the nodes of the Vault cluster, or only subscribe
to events on the active node of the cluster.
If you have multiple event subscribers with the same namespace and event type
filters you have two options:
1. Spread them out among the nodes of the Vault cluster.
1. Only subscribe to events on the active node of the cluster.

Comment on lines +369 to +371
If there are multiple event subscribers with the same namespace and event type
filters, spread them out among the nodes of the Vault cluster, or only subscribe
to events on the active node of the cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If there are multiple event subscribers with the same namespace and event type
filters, spread them out among the nodes of the Vault cluster, or only subscribe
to events on the active node of the cluster.
If you have multiple event subscribers with the same namespace and event type
filters you have two options:
1. Spread them out among the nodes of the Vault cluster.
1. Only subscribe to events on the active node of the cluster.

Edited to match 1.19.x language

Comment on lines +362 to +365
Users may miss events if two or more event clients subscribe to the same
performance standby node in a cluster, and each client specifies the same
namespace and event type filters. If one client disconnects, the other(s) will
no longer receive events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users may miss events if two or more event clients subscribe to the same
performance standby node in a cluster, and each client specifies the same
namespace and event type filters. If one client disconnects, the other(s) will
no longer receive events.
Users may miss events when multiple clients subscribe to the same performance
standby node in a cluster with the same namespace and event type filters because
one client disconnecting unsubscribes the remaining clients who no longer
receive events.

Edited to match 1.19.x language


| Change | Affected version | Fixed version
| ------------ | ---------------------- | --------------------
| Known issue | 1.20.x+ent, 1.19.x+ent | None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Known issue | 1.20.x+ent, 1.19.x+ent | None
| Known issue | 1.20.0+ent | None

We should note the specific version where the problem appears. I'm assuming if we're using ".x" that means it's been there since 1.20.0?


| Change | Affected version | Fixed version
| ------------ | ---------------------- | --------------------
| Known issue | 1.20.x+ent, 1.19.x+ent | None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Known issue | 1.20.x+ent, 1.19.x+ent | None
| Known issue | 1.19.0+ent | None

We should note the specific version where the problem appears. I'm assuming if we're using ".x" that means it's been there since 1.19.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vault IC Higher priority Vault content PR. Update relates to an important changes announcement. Vault Content update for Vault product docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants