Skip to content

Derive Read for Scheme using deriving in BaseUrl #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
+13 −1
Merged

Derive Read for Scheme using deriving in BaseUrl #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a6e727
Derive `Read` for `Scheme` using `deriving` in `BaseUrl` (#1847)
nattybear Oct 23, 2025
be8fe55
Add changelog entry file for PR #1848
nattybear Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions changelog.d/pr-1848
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
synopsis: Derive `Read` instance for `Scheme` in `BaseUrl`
packages: servant-client-core
prs: #1848
issues: #1847
description: {
Added a `Read` instance to the `Scheme` data type in `BaseUrl` via the
`deriving` clause. This allows parsing `Scheme` values from strings using
the standard `Read` mechanism.

This change improves compatibility with libraries like `config-ini`
that rely on the `Read` typeclass for parsing configuration values.
}
2 changes: 1 addition & 1 deletion servant-client-core/src/Servant/Client/Core/BaseUrl.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ data Scheme
Http
| -- | https://
Https
deriving (Data, Eq, Generic, Lift, Ord, Show)
deriving (Data, Eq, Generic, Lift, Ord, Read, Show)

-- | Simple data type to represent the target of HTTP requests
-- for servant's automatically-generated clients.
Expand Down
Loading