Skip to content

Conversation

@ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Dec 15, 2025

Closes #11349
cabal check now recognises SetupHooks.hs as a valid setup script.

QA NOTES

Download the repro in #11349, run cabal check.

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Dec 15, 2025

Does this need backport? I think so, since it influences Hackage behaviour.

@ffaf1 ffaf1 force-pushed the check-setup branch 3 times, most recently from da90f33 to 3c6affb Compare December 15, 2025 17:46
`cabal check` now recognises SetupHooks.hs as a valid setup script.
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ffaf1 ffaf1 added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Dec 15, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Dec 15, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2025

Merge Queue Status

✅ The pull request has been merged at e71de2b

This pull request spent 2 hours 6 minutes 58 seconds in the queue, including 1 hour 55 minutes 46 seconds running CI.
The checks were run on draft #11361.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Dec 17, 2025
@mergify mergify bot merged commit f47e7f4 into haskell:master Dec 17, 2025
214 checks passed
@mergify mergify bot removed the queued label Dec 17, 2025
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Dec 18, 2025

@mergify backport 3.16

@mergify
Copy link
Contributor

mergify bot commented Dec 18, 2025

backport 3.16

✅ Backports have been created

Details

@mergify mergify bot mentioned this pull request Dec 18, 2025
6 tasks
@ffaf1 ffaf1 deleted the check-setup branch December 18, 2025 07:22
mergify bot added a commit that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-backport 3.16 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cabal check complains about a missing Setup.hs script when using build-type: Hooks

3 participants