Skip to content

Support hlint on 9.10 apart from apply-refact #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2025
Merged

Conversation

michaelpj
Copy link
Collaborator

This enables the hlint plugin on GHC 9.10, at the cost of disabling refactoring actions. apply-refact is not even buildable on 9.10, so we have to push this all the way to the cabal file and use CPP, alas.

We have two lines of defense: we don't consider hints applicable if we don't have apply-refact, and if we somehow do get to trying to apply a hint, we fail.

@michaelpj michaelpj requested a review from fendor June 7, 2025 15:34
@michaelpj michaelpj requested a review from eddiemundo as a code owner June 7, 2025 15:34
This enables the hlint plugin on GHC 9.10, at the cost of disabling
refactoring actions. `apply-refact` is not even buildable on 9.10, so we
have to push this all the way to the cabal file and use CPP, alas.

We have two lines of defense: we don't consider hints applicable if we
don't have `apply-refact`, and if we somehow do get to trying to apply a
hint, we fail.
@michaelpj michaelpj force-pushed the mpj/enable-hlint-910 branch from e2456f0 to 74dd77d Compare June 7, 2025 15:53
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fendor fendor added the merge me Label to trigger pull request merge label Jun 8, 2025
Copy link
Contributor

mergify bot commented Jun 8, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot merged commit 9adae74 into master Jun 8, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants