Use POSIX_SPAWN_CLOEXEC_DEFAULT in posix_spawn.c when available #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good, thanks @thomasjm! |
Contributor
Author
Contributor
Author
|
@bgamari hoping to get your attention here ^ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking at improving performance when
close_fds=Trueafter encountering #189.I noticed this could be improved on MacOS where this flag is available. Making the
do_spawn_posixfunction handle more situations will result in fewer fallbacks to the (possibly less performant)do_spawn_fork.I haven't tested this yet, hoping to see how it works on CI.