Derive all Unbox instance for newtypes using GND #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to define instances using language facilities instead of relying on CPP. Sadly GHC8.0 fails to build these for some reason
Contributor
Author
|
Now that we dropped support for GHC<8.8 this PR finally could be merged. switching to DerivingVia for other instances will happen in separate PR since it's not ready yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to define instances using language facilities instead of relying on CPP.
Last time I tried to do this GHC8.0 chocked and died during deriving. I still create PR so it could be merged once we drop support for GHC 8.0