Skip to content

Add GHC-17335 #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Add GHC-17335 #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b802cd2
Add GHC-17335
hsyl20 Jun 6, 2024
5bf88c8
Review suggestions for GHC-17335
Bodigrim Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions message-index/messages/GHC-17335/dsIncompleteRecSel/after/DsIncompleteRecSel.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module DsIncompleteRecSel where

data T = T1 | T2 {x :: Bool}

f :: T -> Bool
f T1 = True -- handle the T1 case
f a = x a
6 changes: 6 additions & 0 deletions message-index/messages/GHC-17335/dsIncompleteRecSel/before/DsIncompleteRecSel.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
module DsIncompleteRecSel where

data T = T1 | T2 {x :: Bool}

f :: T -> Bool
f a = x a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could adding a type signature f :: T -> Bool be beneficial for readers?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed addition of type signatures to the branch.

3 changes: 3 additions & 0 deletions message-index/messages/GHC-17335/dsIncompleteRecSel/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
title: Incomplete record selector application
---
13 changes: 13 additions & 0 deletions message-index/messages/GHC-17335/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
title: Incomplete record selector application
summary: A record selector application may not be successful
severity: warning
flag: -Wincomplete-record-selectors
introduced: 9.10.1
---

This warning is triggered when GHC is not certain whether a record selector
application will be successful. This happens when a record selector is not
defined for all constructors of a data type (a.k.a. partial record field
selector) and it is applied to a value whose data constructor can't be proved by
GHC to be one for which the selector is defined.