Add documentation for GHC-21926 #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
Feb 2, 2025
Bodigrim
reviewed
Feb 2, 2025
message-index/messages/GHC-21926/version-number-in-package/index.md
Outdated
Show resolved
Hide resolved
Bodigrim
reviewed
Feb 9, 2025
| extension: PackageImports | ||
| --- | ||
|
|
||
| Version number or non-alphanumeric character in the package. Alphanumeric characters are letters and numbers, as defined by `Data.Char.isAlphaNum`. |
There was a problem hiding this comment.
That's a bit incomplete: a package name can include dashes, even while Data.Char.isAlphaNum '-' = False.
The actual function GHC uses to validate package names is
looksLikePackageName = all (all isAlphaNum <&&> not . (all isDigit)) . split '-'So probably something like "Each of dash-separated components of package name must consist of alphanumeric characters (as defined by Data.Char.isAlphaNum), at least one of which is not a digit". What do you think?
There was a problem hiding this comment.
Sorry for the late reply. Sounds good! Changed the code 👍
There was a problem hiding this comment.
Did you push anything? I don't see any changes.
There was a problem hiding this comment.
Yikes, rookie mistake. Pushed as f1fde5c (#514).
Apologies for the inconvenience.
Bodigrim
approved these changes
Feb 22, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the card I drew during ZuriHac! 📇
This is quite a simple parser error, which can be hit when
PackageImportsis enabled. The error itself is quite clear already: don't put version numbers and non-alphanumeric characters in a package import.I'm not sure how one would get into the non-alphanumeric character situation (besides an honest typo), but the version one is quite a fair mistake to make.