Skip to content

Feat/subhan fixes issue1#7

Merged
hasnaintypes merged 11 commits into
developfrom
feat/subhan-fixes-issue1
Mar 7, 2026
Merged

Feat/subhan fixes issue1#7
hasnaintypes merged 11 commits into
developfrom
feat/subhan-fixes-issue1

Conversation

@M-Subhan-Ali
Copy link
Copy Markdown
Contributor

@M-Subhan-Ali M-Subhan-Ali commented Mar 4, 2026

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • UI/UX improvement
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test addition or update
  • Configuration change

Related Issues

  • Closes #
  • Related to #

Changes Made

Testing Done

  • Tested locally in development environment
  • Tested in production-like environment
  • Added unit tests
  • Added integration tests
  • Tested on multiple browsers (Chrome, Firefox, Safari, Edge)
  • Tested mobile responsiveness
  • Verified backward compatibility

Test Steps

Screenshots / Videos

Before

After

Documentation

  • Documentation has been updated (README, CONTRIBUTING, etc.)
  • Code comments have been added/updated
  • No documentation changes needed

Breaking Changes

Code Review Checklist

  • Code follows the project's coding standards
  • Changes are well-documented
  • No unnecessary dependencies added
  • Git history is clean (meaningful commits, no merge commits)
  • Tests pass locally and in CI
  • No console errors or warnings
  • Performance impact considered
  • Security implications considered

Additional Notes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

🤖 Auto-generated PR description has been added!

The title and description were generated based on your commits and file changes.
Please review and update:

  • ✏️ Edit the description to add more context if needed
  • 🔗 Link related issues using Closes #123
  • ✅ Check the boxes for type of change and testing done
  • 📷 Add screenshots/videos if UI changes were made

See our Contributing Guidelines for best practices.

github-actions[bot]
github-actions Bot reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Sendable.ai!

Thank you for opening your first pull request!

We're excited to review your contribution. Here's what happens next:

  1. Automated checks will run to verify your code
  2. A maintainer will review your changes
  3. You may receive feedback or change requests
  4. Once approved, your PR will be merged!

Quick tips:

  • Make sure all CI checks pass
  • Respond to any feedback promptly
  • Keep your PR focused on a single concern
  • Check out our Contributing Guide for best practices

Thank you for contributing!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026 •
edited
Loading

Dependency Review Summary

The full dependency review summary was too large to display here (1395KB, limit is 1024KB).

Please download the artifact named "dependency-review-summary" to view the complete report.

View full job summary

@M-Subhan-Ali
feat: Introduce email templates for authentication and notifications,…
3c5df2c 
… add an email verification page, and establish a GitHub Actions CI workflow, while removing the npm lock file.
@github-actions github-actions Bot added the ci-cd label Mar 4, 2026
@M-Subhan-Ali M-Subhan-Ali self-assigned this Mar 5, 2026
@M-Subhan-Ali
feat: Implement email-based authentication flows including verificati…
ab90521 
…on, OTP, magic links, and password reset with corresponding email templates and UI.
@github-actions github-actions Bot added the email label Mar 6, 2026
github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 6, 2026
View reviewed changes
Comment thread convex/emails/email.tsx
@@ -1,86 +1,206 @@
"use node";

Check warning

Code scanning / CodeQL

Unknown directive Warning

Unknown directive: 'use node'.

Copilot Autofix

AI 2 months ago

In general, to fix an "Unknown directive" problem you either (1) correct the directive to a valid, intended one (e.g., change typos like "usestrict" to "use strict"), or (2) remove the string if no directive semantics are needed. For Convex server-side actions/components, the recognized directive to indicate server code is "use server" at the top of the file.

The best fix here, without changing existing functionality, is to replace "use node"; on line 1 with the correct, supported directive "use server";. This keeps the intent of marking the file as server-only code (which is consistent with its use of Convex action, ActionCtx, and Node-only modules like nodemailer), while eliminating the unknown directive warning. No other lines in convex/emails/email.tsx need to change, and no new imports or helper methods are required.

Concretely: in convex/emails/email.tsx, update line 1 from "use node"; to "use server";. All other code remains unchanged.

Suggested changeset 1
convex/emails/email.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/convex/emails/email.tsx b/convex/emails/email.tsx
--- a/convex/emails/email.tsx
+++ b/convex/emails/email.tsx
@@ -1,4 +1,4 @@
-"use node";
+"use server";
 
 import "../polyfills";
 import VerifyEmail from "./templates/VerifyEmail";
EOF
@@ -1,4 +1,4 @@
"use node";
"use server";

import "../polyfills";
import VerifyEmail from "./templates/VerifyEmail";
Copilot is powered by AI and may make mistakes. Always verify output.
Comment thread convex/emails/templates/BaseLayout.tsx Fixed
Comment thread src/app/(unauth)/verify-email/page.tsx Fixed
hasnaintypes
hasnaintypes approved these changes Mar 7, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@hasnaintypes hasnaintypes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am merging it

@hasnaintypes hasnaintypes merged commit 27e7143 into develop Mar 7, 2026
8 checks passed
@hasnaintypes hasnaintypes deleted the feat/subhan-fixes-issue1 branch March 7, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hasnaintypes hasnaintypes hasnaintypes approved these changes

Assignees

@M-Subhan-Ali M-Subhan-Ali

Labels

auth backend ci-cd dependencies documentation Improvements or additions to documentation email feature frontend size/large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@M-Subhan-Ali @github-advanced-security @hasnaintypes