Fix HID stylus descriptor and hid_composite example #3280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes HID stylus descriptor and example implementation issues that cause Windows driver errors and cursor locking problems.
- Corrects HID stylus descriptor usage declarations that were causing Windows "Driver Error Code: code 10"
- Refactors stylus touch handling in hid_composite example to prevent cursor locking on Windows
- Integrates stylus touch logic into the existing button-driven HID report system
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/class/hid/hid_device.h | Fixed HID stylus descriptor to use HID_USAGE instead of HID_USAGE_PAGE for tip switch and in-range usages |
| examples/device/hid_composite/src/main.c | Refactored stylus touch handling from automatic periodic sending to button-driven reports within send_hid_report function |
HiFiPhile
changed the title
Signed-off-by: HiFiPhile <[email protected]>
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
HID_USAGE_DIGITIZER_TIP_SWITCHandHID_USAGE_DIGITIZER_IN_RANGEare usage but not page, resultingDriver Error Code: code 10 "A non constant main item was declaired without a corresponding usage"on Windows (MSFT madedeclairedtypo)send_stylus_touchinhid_taskwithout waiting for button event is really bad, on Windows it locks the cursor to top left once the USB port is connected.