Add ability to enable camera in personal office #9190
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The camera in the personal office is turned off by default, but users now have the option to enable it in their office Signed-off-by: Anton Alexeyev <[email protected]>
|
Connected to Huly®: UBERF-11444 |
haiodo
reviewed
Jun 9, 2025
| export let width: string | undefined = 'fit-content' | ||
|
|
||
| $: booleanValue = value === RoomType.Video | ||
| $: disabled = object === undefined || !('person' in object) || (object as Office).person !== getCurrentEmployee() |
There was a problem hiding this comment.
so it will be enabled for me in my office, and disabled for me in any other office? why?
There was a problem hiding this comment.
So that users cannot turn on the camera in other people's offices. Should this be allowed?
There was a problem hiding this comment.
Please use isOffice func. It should be $: disabled = object === undefined || (isOffice(object) && object.person !== getCurrentEmployee())
But office meetings should start with all participants' cameras turned off Signed-off-by: Anton Alexeyev <[email protected]>
utkaka
force-pushed
the
personal-office-camera
branch
from
bbcec64 to
d75ac6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera in the personal office is turned off by default, but users now have the option to enable it in their office