fix: cancel image loading when not visible #9625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Onnikov <[email protected]>
|
Connected to Huly®: UBERF-12914 |
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to cancel image loading when images are not visible, optimizing performance by preventing unnecessary network requests for off-screen images. The changes introduce a continuous visibility tracking mode to the lazy loading system and apply it to image components.
- Adds continuous observation mode to the lazy loading utility to track when elements become visible/invisible
- Implements visibility-based image loading that cancels requests when images go out of view
- Updates configuration to use new image service endpoints
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/ui/src/lazy.ts | Adds continuous observation mode and convenience functions for different lazy loading behaviors |
| packages/presentation/src/components/Image.svelte | Implements visibility tracking to conditionally load images based on viewport presence |
| dev/prod/public/config-dev.json | Updates configuration with new image and file service URLs |
Signed-off-by: Alexander Onnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.