Open
Conversation
Replaced saveTask action with an observer because I couldn’t get the checkbox to hit an action. However, the observer fires uncontrollably. Also, how should I modify my test? Using Ember.Checkbox, there doesn’t seem to be anything in the markup to differentiate checked from unchecked boxes. Should I check the completedAt property in the model? Seems wrong to do that in an integration test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use a checkbox input instead of a button, I had to replace the
saveTaskaction with an observer on the task'sisCompletedproperty because I couldn’t get the checkbox to hit an action.However, the observer fires uncontrollably. See issue #31 .
Also, I need to figure out how to change my test now, since it's failing. (Using Ember.Checkbox, there doesn’t
seem to be anything in the markup to differentiate checked from unchecked boxes. Should I check the completedAt property in the model? Seems wrong to do that in an integration test.)