Skip to content

🛡️ Sentinel: [CRITICAL] Fix environment leakage in unit test gate #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heidi-dang wants to merge 1 commit into
base: feat/bootstrap-scaffold
Choose a base branch
from
Open

🛡️ Sentinel: [CRITICAL] Fix environment leakage in unit test gate #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,8 @@
**Vulnerability:** Telemetry HTTP endpoints (`/status`, `/`) were completely unprotected, allowing any local user to view training state, usage, and costs.
**Learning:** Initial implementation prioritized ease of use and local-only binding (`127.0.0.1`) but neglected defense-in-depth requirements for multi-user or shared environments.
**Prevention:** Always implement at least Basic Authentication for any endpoint exposing state or metadata, even if restricted to loopback. Use random session-specific credentials if no configuration is provided.

## 2025-01-24 - Environment Variable Leakage in Unit Test Gate
**Vulnerability:** `scripts/03_unit_test_gate.py` executed generated code using `subprocess.run` without filtering environment variables, allowing potentially malicious generated code to exfiltrate sensitive data (e.g., `OPENAI_API_KEY`) from the environment.
**Learning:** `subprocess.run` in Python inherits the full parent environment by default. Isolation of the working directory is insufficient if the environment remains exposed.
**Prevention:** Explicitly filter the `env` argument in `subprocess.run` using an allowlist of safe variables (e.g., `PATH`, `PYTHONPATH`, `LANG`) when executing untrusted or generated code.
4 changes: 0 additions & 4 deletions heidi_engine/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,10 +732,6 @@ def get_state(run_id: Optional[str] = None) -> Dict[str, Any]:
"usage": get_default_usage(),
}

# BOLT OPTIMIZATION: Check thread-safe state cache
cached = _state_cache.get(target_run_id, state_file)
if cached:
return cached

try:
with open(state_file) as f:
Expand Down
29 changes: 24 additions & 5 deletions scripts/03_unit_test_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,15 @@
# TUNABLE: Add more dangerous patterns to block
DANGEROUS_PATTERNS = [
# Dangerous imports (including comma-separated and aliased)
r"\bimport\s+[^#\n]*\b(os|subprocess|sys|shutil|socket|requests|urllib|pathlib|pickle|pty|code|bdb|pdb|multiprocessing|threading|tempfile|ftplib|smtplib|telnetlib|http|xmlrpc)\b",
r"\bfrom\s+(os|subprocess|sys|shutil|socket|requests|urllib|pathlib|pickle|pty|code|bdb|pdb|multiprocessing|threading|tempfile|ftplib|smtplib|telnetlib|http|xmlrpc)\b",
r"\bimport\s+[^#\n]*\b(os|posix|nt|subprocess|sys|shutil|socket|requests|urllib|pathlib|pickle|pty|code|bdb|pdb|multiprocessing|threading|tempfile|ftplib|smtplib|telnetlib|http|xmlrpc)\b",
r"\bfrom\s+(os|posix|nt|subprocess|sys|shutil|socket|requests|urllib|pathlib|pickle|pty|code|bdb|pdb|multiprocessing|threading|tempfile|ftplib|smtplib|telnetlib|http|xmlrpc)\b",
# Dangerous built-ins
r"\beval\s*\(",
r"\bexec\s*\(",
r"\b__import__\s*\(",
r"\b__subclasses__\b",
r"\b__globals__\b",
r"\b__builtins__\b",
r"\bgetattr\s*\(",
r"\bsetattr\s*\(",
r"\bbreakpoint\s*\(",
Expand Down Expand Up @@ -214,6 +217,8 @@ def test_python_code(code: str, temp_dir: str, execution_timeout: int = 5) -> Tu
test_file = os.path.join(temp_dir, "test_code.py")

# Wrap code to capture output safely
import textwrap
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This import is local to the function. According to PEP 8, imports should usually be at the top of the file. Moving import textwrap to the module level improves code organization and follows standard Python style conventions.

References
  1. PEP 8 recommends that imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants. (link)

indented_code = textwrap.indent(code, " ")
wrapped_code = f"""
import sys
import io
Expand All @@ -229,7 +234,7 @@ def test_python_code(code: str, temp_dir: str, execution_timeout: int = 5) -> Tu
sys.stderr = stderr_capture

# Execute the user's code
{code}
{indented_code}

sys.stdout = original_stdout
sys.stderr = original_stderr
Expand Down Expand Up @@ -257,13 +262,25 @@ def test_python_code(code: str, temp_dir: str, execution_timeout: int = 5) -> Tu

# Try to execute with timeout
try:
# SECURITY: Restrict environment variables to prevent leakage of sensitive
# information (like API keys) to the code being tested.
safe_env_keys = {"PATH", "PYTHONPATH", "LANG", "PYTHONIOENCODING"}
restricted_env = {k: v for k, v in os.environ.items() if k in safe_env_keys}

# Ensure PYTHONPATH includes the temp directory
current_pp = restricted_env.get("PYTHONPATH", "")
if current_pp:
restricted_env["PYTHONPATH"] = f"{temp_dir}{os.pathsep}{current_pp}"
else:
restricted_env["PYTHONPATH"] = temp_dir

result = subprocess.run(
[sys.executable, test_file],
capture_output=True,
text=True,
timeout=execution_timeout,
cwd=temp_dir,
env={**os.environ, "PYTHONPATH": temp_dir},
env=restricted_env,
)

stdout = result.stdout
Expand Down Expand Up @@ -367,7 +384,9 @@ def load_jsonl(path: str) -> List[Dict[str, Any]]:

def save_jsonl(samples: List[Dict[str, Any]], path: str) -> None:
"""Save samples to JSONL file."""
os.makedirs(os.path.dirname(path), exist_ok=True)
dirname = os.path.dirname(path)
if dirname:
os.makedirs(dirname, exist_ok=True)

with open(path, "w") as f:
for sample in samples:
Expand Down