fix: add error isolation to prevent WebUI crashes, server disconnections, and agent stalling #32
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,99 +18,103 @@ export function createToolExecuteBeforeHandler(args: { | |
| const { ctx, hooks } = args | ||
|
|
||
| return async (input, output): Promise<void> => { | ||
| try { | ||
| await hooks.planEnforcement?.["tool.execute.before"]?.(input, output) | ||
| await hooks.semanticLoopGuard?.["tool.execute.before"]?.(input, output) | ||
| await hooks.carRuntime?.["tool.execute.before"]?.(input, output) | ||
|
|
||
| await hooks.writeExistingFileGuard?.["tool.execute.before"]?.(input, output) | ||
| await hooks.questionLabelTruncator?.["tool.execute.before"]?.(input, output) | ||
| await hooks.claudeCodeHooks?.["tool.execute.before"]?.(input, output) | ||
| await hooks.nonInteractiveEnv?.["tool.execute.before"]?.(input, output) | ||
| await hooks.commentChecker?.["tool.execute.before"]?.(input, output) | ||
| await hooks.directoryAgentsInjector?.["tool.execute.before"]?.(input, output) | ||
| await hooks.directoryReadmeInjector?.["tool.execute.before"]?.(input, output) | ||
| await hooks.rulesInjector?.["tool.execute.before"]?.(input, output) | ||
| await hooks.tasksTodowriteDisabler?.["tool.execute.before"]?.(input, output) | ||
| await hooks.prometheusMdOnly?.["tool.execute.before"]?.(input, output) | ||
| await hooks.sisyphusJuniorNotepad?.["tool.execute.before"]?.(input, output) | ||
| await hooks.atlasHook?.["tool.execute.before"]?.(input, output) | ||
|
|
||
| const normalizedToolName = input.tool.toLowerCase() | ||
| if ( | ||
| normalizedToolName === "question" | ||
| || normalizedToolName === "ask_user_question" | ||
| || normalizedToolName === "askuserquestion" | ||
| ) { | ||
| const sessionID = input.sessionID || getMainSessionID() | ||
| await hooks.sessionNotification?.({ | ||
| event: { | ||
| type: "tool.execute.before", | ||
| properties: { | ||
| sessionID, | ||
| tool: input.tool, | ||
| args: output.args, | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| if (input.tool === "task") { | ||
| const argsObject = output.args | ||
| const category = typeof argsObject.category === "string" ? argsObject.category : undefined | ||
| const subagentType = typeof argsObject.subagent_type === "string" ? argsObject.subagent_type : undefined | ||
| const sessionId = typeof argsObject.session_id === "string" ? argsObject.session_id : undefined | ||
|
|
||
| if (category) { | ||
| argsObject.subagent_type = "sisyphus-junior" | ||
| } else if (!subagentType && sessionId) { | ||
| const resolvedAgent = await resolveSessionAgent(ctx.client, sessionId) | ||
| argsObject.subagent_type = resolvedAgent ?? "continue" | ||
| } | ||
| } | ||
|
|
||
| if (hooks.ralphLoop && input.tool === "skill") { | ||
| const rawName = typeof output.args.name === "string" ? output.args.name : undefined | ||
| const command = rawName?.replace(/^\//, "").toLowerCase() | ||
| const sessionID = input.sessionID || getMainSessionID() | ||
|
|
||
| if (command === "ralph-loop" && sessionID) { | ||
| const rawArgs = rawName?.replace(/^\/?(ralph-loop)\s*/i, "") || "" | ||
| const parsedArguments = parseRalphLoopArguments(rawArgs) | ||
|
|
||
| hooks.ralphLoop.startLoop(sessionID, parsedArguments.prompt, { | ||
| maxIterations: parsedArguments.maxIterations, | ||
| completionPromise: parsedArguments.completionPromise, | ||
| strategy: parsedArguments.strategy, | ||
| }) | ||
| } else if (command === "cancel-ralph" && sessionID) { | ||
| hooks.ralphLoop.cancelLoop(sessionID) | ||
| } else if (command === "ulw-loop" && sessionID) { | ||
| const rawArgs = rawName?.replace(/^\/?(ulw-loop)\s*/i, "") || "" | ||
| const parsedArguments = parseRalphLoopArguments(rawArgs) | ||
|
|
||
| hooks.ralphLoop.startLoop(sessionID, parsedArguments.prompt, { | ||
| ultrawork: true, | ||
| maxIterations: parsedArguments.maxIterations, | ||
| completionPromise: parsedArguments.completionPromise, | ||
| strategy: parsedArguments.strategy, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| if (input.tool === "skill") { | ||
| const rawName = typeof output.args.name === "string" ? output.args.name : undefined | ||
| const command = rawName?.replace(/^\//, "").toLowerCase() | ||
| const sessionID = input.sessionID || getMainSessionID() | ||
|
|
||
| if (command === "stop-continuation" && sessionID) { | ||
| hooks.stopContinuationGuard?.stop(sessionID) | ||
| hooks.todoContinuationEnforcer?.cancelAllCountdowns() | ||
| hooks.ralphLoop?.cancelLoop(sessionID) | ||
| clearBoulderState(ctx.directory) | ||
| log("[stop-continuation] All continuation mechanisms stopped", { | ||
| sessionID, | ||
| }) | ||
| } | ||
| } | ||
| } catch (err: unknown) { | ||
| log("[tool-execute-before.ts] Unhandled hook error caught:", { error: err instanceof Error ? err.message : String(err) }) | ||
| } | ||
|
Comment on lines
+116
to
118
There was a problem hiding this comment. As noted in the PR description, this For example: } catch (err: unknown) {
if (isSafetyCriticalHookError(err)) { // `isSafetyCriticalHookError` would need to be defined/imported
throw err;
}
log("[tool-execute-before.ts] Unhandled hook error caught:", { error: err instanceof Error ? err.message : String(err) })
} |
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silently swallowing errors can make debugging difficult. It's better to log the error to aid in troubleshooting potential issues with notifications.
You'll also need to import the
logfunction at the top of the file:import { log } from "../shared/logger";