Add feature: Choose preferred scheme name.#23
Open
oscarssanchez wants to merge 1 commit intohelen:developfrom
Open
Add feature: Choose preferred scheme name.#23oscarssanchez wants to merge 1 commit intohelen:developfrom
oscarssanchez wants to merge 1 commit intohelen:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @helen,
Could you use this PR that aims to add the feature requested in #16 ?
I'm not sure if my approach is intuitive enough to the end user, so it would be great to read some feedback.
So this is what the functionality looks like now:
When no name is provided the scheme name defaults to Custom
Example of adding a name to the custom scheme.
Maybe outputting an error if no scheme name is provided would be a better approach, which would be also related to issue #7
Thank you!