Dual rpc provider #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deasydoesit
commented
Jul 6, 2023
| @@ -1,7 +1,6 @@ | |||
| .DS_Store | |||
| /node_modules | |||
| *-lock.* | |||
| *.lock | |||
|
|
|||
There was a problem hiding this comment.
Don't ignore package-lock.json
ChewingGlass
suggested changes
Jul 6, 2023
src/utils/pegRpcProviderByModulus.ts
Outdated
| // - is provided by client application | ||
| // - is of number type (so modulus operation won't throw) | ||
| // CURRRENTLY THIS BLOCK WILL NEVER BE ENTERED | ||
| if (clientIdentifier && typeof clientIdentifier === 'number') { |
There was a problem hiding this comment.
Won't a header value always be a string? We should just make client identifier any string, then hash the string and take a modulus on the hash
There was a problem hiding this comment.
I really didn't want the conditional to be entered until we're ready so I added the typeof check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the dual rpc provider paradigm,
index.tsserves as the "router" for determining if a request should be proxied to Helius or Triton, where theheliusHandlerfunction provided byheliusHandler.tshandles Helius requests andtritonHandlerfunction provided bytritonHandler.tshandles Triton requests.heliusHandleris largely identical to the previousindex.tsfile.