Skip to content

fix: guard getItem against null/empty data and out-of-range index #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shawerestart wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: guard getItem against null/empty data and out-of-range index #18

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d227fa5
fix: android change config list too fast cause crash
May 7, 2026
e55789c
fix: remove blank line
May 7, 2026
7314117
update: docs
May 7, 2026
0b04e76
Update README.cn.md
shawerestart May 9, 2026
1ec94d3
Update README.md
shawerestart May 9, 2026
b1576a4
Update README.cn.md
shawerestart May 9, 2026
c26505e
Update README.md
shawerestart May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion android/src/main/java/com/github/fujianlian/klinechart/BaseKLineChartView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,7 +1028,14 @@ public void drawVolLine(Canvas canvas, Paint paint, float startX, float startVal
* @return
*/
public KLineEntity getItem(int position) {
return configManager.modelArray.get(position);
int size = configManager.modelArray == null ? 0 : configManager.modelArray.size();
if (size <= 0) {
KLineEntity empty = new KLineEntity();
empty.Date = "";
return empty;
}
int safeIndex = Math.max(0, Math.min(position, size - 1));
return configManager.modelArray.get(safeIndex);
}

/**
Expand Down