2017-Overdeadline-ostrich2821 js-homework #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evafly
suggested changes
Aug 4, 2017
|
|
||
| var BMI = getBMI(1.5, 50); | ||
|
|
||
| function getMessage(){ |
There was a problem hiding this comment.
因為作業的題目是getMessage函式可以傳入height與weight，所以這邊建議把bmi放到函式內，並讓getMessage傳入height與weight兩個參數，然後在getMessage內呼叫getBMI，例如:
function getMessage(height,weight){
var BMI=getBMI(height,weight);
......
}
| }else if(18.5 <= BMI && 24 > BMI){ | ||
| console.log('正常範圍'); | ||
| }else{ | ||
| console.log('異常範圍'); |
| } | ||
| } | ||
|
|
||
| getMessage(); |
There was a problem hiding this comment.
這邊再console.log(getMessage(1.5,50));印出結果就好
Evafly
reviewed
Aug 4, 2017
| @@ -0,0 +1,21 @@ | |||
| function getBMI(height,weight){ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.