-
Notifications
You must be signed in to change notification settings - Fork 29
week2-HW #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShuTLIN
wants to merge
1
commit into
hellojs-tw:master
Choose a base branch
from
ShuTLIN:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
week2-HW #29
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
function getBMI(height,weight){ | ||
var result=weight/(height*height); | ||
return result; | ||
}; | ||
|
||
function getMessage(height,weight){ | ||
var result=weight/(height*height); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 這裡可以直接用result=getBMI(height,weight);就好囉,可以不用再多計算一次 |
||
if (result>24) { | ||
var answer='BMI過高 體重正常範圍為 BMI=18.5~24 '; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 小小建議:直接 |
||
return answer; | ||
} | ||
if(result>18.5){ | ||
var answer='BMI過低 體重正常範圍為 BMI=18.5~24 '; | ||
return answer; | ||
} | ||
else{ | ||
var answer='體重位於正常範圍 體重正常範圍為 BMI=18.5~24 '; | ||
return answer; | ||
} | ||
}; | ||
|
||
console.log(getBMI(1, 52)); | ||
console.log(getMessage(1, 52)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"name": "js-101-practice", | ||
"version": "1.0.0", | ||
"description": "[BMI 計算機](http://depart.femh.org.tw/dietary/3OPD/BMI.htm)", | ||
"main": "2017-deadlineclub-s0461117.js", | ||
"scripts": { | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "git+https://github.com/s0461117/js-101-practice.git" | ||
}, | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC", | ||
"bugs": { | ||
"url": "https://github.com/s0461117/js-101-practice/issues" | ||
}, | ||
"homepage": "https://github.com/s0461117/js-101-practice#readme" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
記得
//你的大名
歐