feat: skip values.yaml yamllint when file is absent #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
force-pushed
the
missing-values-yaml
branch
2 times, most recently
from
ac0da3f to
beff95c
Compare
|
Not sure why the DCO check is failing, I just added the required byline. Update: Resolved. |
thiagowfx
force-pushed
the
missing-values-yaml
branch
from
beff95c to
9bc13ab
Compare
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
!stayalive |
TerryHowe
reviewed
Sep 27, 2025
cpanato
reviewed
Oct 8, 2025
cpanato
reviewed
Oct 8, 2025
|
Thanks for the feedback. Aiming to update it this month. Edit: Updated. |
Resolve issue where ct lint fails when values.yaml is missing from a chart directory. Validate values.yaml with yamllint if the file actually exists, allowing charts without configurable values to pass linting successfully. Testing: - All existing tests continue to pass - New test specifically validates that yamllint is only called once (for Chart.yaml) when values.yaml is missing - Code passes go vet, go fmt, and golangci-lint checks Behavior: - Before: ct lint would fail if values.yaml was missing from a chart, even when validate-yaml: true was set - After: ct lint gracefully skips yamllint validation for values.yaml when the file doesn't exist, allowing charts without configurable values to lint successfully Fixes helm#748 Signed-off-by: Thiago Perrotta <[email protected]>
thiagowfx
force-pushed
the
missing-values-yaml
branch
from
72a1f46 to
5ef7b74
Compare
Signed-off-by: Thiago Perrotta <[email protected]>
thiagowfx
force-pushed
the
missing-values-yaml
branch
2 times, most recently
from
175baed to
fd4be7e
Compare
Signed-off-by: Thiago Perrotta <[email protected]>
thiagowfx
force-pushed
the
missing-values-yaml
branch
from
fd4be7e to
074227e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue where ct lint fails when values.yaml is missing from a chart directory. Validate values.yaml with yamllint if the file actually exists, allowing charts without configurable values to pass linting successfully.
Testing:
Chart.yaml) when values.yaml is missing
Behavior:
Fixes #748
Signed-off-by: Thiago Perrotta [email protected]