Skip to content

Fix symlink to hardlink on mac #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raphaelvigee wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix symlink to hardlink on mac #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8203a62
Add some smart for hardlink to symlink
raphaelvigee Dec 17, 2024
4f139df
eh
raphaelvigee Dec 17, 2024
b2289ab
Merge branch 'master' into symlinkmac
raphaelvigee Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions sandbox/sandbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,22 @@ func Make(ctx context.Context, cfg MakeConfig) error {
}
untarDedup.Add(to)

err := xfs.CreateParentDir(to)
err = xfs.CreateParentDir(to)
if err != nil {
return err
}

err = os.Link(file.From, to)
if err != nil {
return fmt.Errorf("make: link %v to %v: %w", file.From, to, err)
target, err := os.Readlink(file.From)
if err == nil {
err = os.Symlink(target, to)
if err != nil {
return err
}
} else {
err = os.Link(file.From, to)
if err != nil {
return fmt.Errorf("make: link %v to %v: %w", file.From, to, err)
}
}

if cfg.ProgressLinks != nil {
Expand Down
6 changes: 6 additions & 0 deletions utils/xstarlark/fmt/fmt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,12 @@ func (f *formatter) formatStmt(w Writer, sstmt syntax.Stmt) error {
return err
}
case *syntax.ReturnStmt:
if stmt.Result == nil {
w.WriteString("return")

return nil
}

w.WriteString("return ")
return f.formatExpr(w, stmt.Result)
case *IfStmt:
Expand Down
Loading