Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge /api/improve and /api/alternatives, remove custom Herbie properties #1164

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

pavpanchekha
Copy link
Contributor

The core idea behind this PR is that both of these APIs return JSON blobs, and those JSON blobs have distinct sets of keys. So we can just merge both endpoints and return both sets of keys, and everyone will be happy.

Doing this is quite involved, and required:

  • Deleting alternatives in favor of improve
  • Adding alternatives, histories, and derivations keys to make-improve-result
  • Dropping :herbie keys from unparse-result
  • Dropping unparse-result in favor of alternatives (which is an FPCore)
  • Fixing the alternatives key in case of a string name with spaces

@pavpanchekha
Copy link
Contributor Author

This is still WIP, because there are still some non-JSON data structures in the histories portion that need to be JSONified. Ugh.

@pavpanchekha
Copy link
Contributor Author

This continues moving along, there are now only two non-JSON things being returned by alternatives:

  • The test, which unfortunately is widely used
  • The start, which likewise

We really ought to redo this and make it saner to start, but 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant