Merge /api/improve
and /api/alternatives
, remove custom Herbie properties
#1164
+137
−204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core idea behind this PR is that both of these APIs return JSON blobs, and those JSON blobs have distinct sets of keys. So we can just merge both endpoints and return both sets of keys, and everyone will be happy.
Doing this is quite involved, and required:
alternatives
in favor ofimprove
alternatives
,histories
, andderivations
keys tomake-improve-result
:herbie
keys fromunparse-result
unparse-result
in favor ofalternatives
(which is an FPCore)alternatives
key in case of a string name with spaces