Skip to content

fix(input): keep shift on letters that report only an alternate codepoint - #2436

Closed
farzadmf wants to merge 2 commits into
herdrdev:masterfrom
farzadmf:master
Closed

fix(input): keep shift on letters that report only an alternate codepoint#2436
farzadmf wants to merge 2 commits into
herdrdev:masterfrom
farzadmf:master

Conversation

@farzadmf

@farzadmf farzadmf commented Aug 6, 2026

Copy link
Copy Markdown

WezTerm kitty mode sends shift+ with no SHIFT bit, only the uppercase alternate codepoint, so it matched the unshifted binding.

Fixes #2435

…oint

WezTerm kitty mode sends shift+<letter> with no SHIFT bit, only the
uppercase alternate codepoint, so it matched the unshifted binding.
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a3486bbf-6bf5-4678-a1c3-1287d284d985

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@kangal-bot

Copy link
Copy Markdown
Collaborator

Hi @farzadmf, thanks for your interest in contributing.

Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in .github/APPROVED_CONTRIBUTORS.

The pull request author is not an approved contributor.

If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents.

Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written.

If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically.

See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy.

@kangal-bot kangal-bot closed this Aug 6, 2026
@farzadmf

farzadmf commented Aug 7, 2026

Copy link
Copy Markdown
Author

Hopelessly pinging @ogulcancelik similar to #2270 as this is a big blocker for me on Wezterm

EDIT: by "similar to ...", I mean I think pinging you allowed the PR to go through, hopefully same will happen to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shift+letter keybindings do not match in WezTerm kitty mode

2 participants