fix(input): keep shift on letters that report only an alternate codepoint - #2436
fix(input): keep shift on letters that report only an alternate codepoint#2436farzadmf wants to merge 2 commits into
Conversation
…oint WezTerm kitty mode sends shift+<letter> with no SHIFT bit, only the uppercase alternate codepoint, so it matched the unshifted binding.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Hi @farzadmf, thanks for your interest in contributing. Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in The pull request author is not an approved contributor. If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents. Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written. If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
|
Hopelessly pinging @ogulcancelik similar to #2270 as this is a big blocker for me on Wezterm EDIT: by "similar to ...", I mean I think pinging you allowed the PR to go through, hopefully same will happen to this |
WezTerm kitty mode sends shift+ with no SHIFT bit, only the uppercase alternate codepoint, so it matched the unshifted binding.
Fixes #2435