Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/next/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- Experimental pane graphics now support bounded named layers, acknowledged full-RGBA primary-layer direct file frames on audited local terminals, owned BGRA fallback, exact pixel mouse input, and placement-only resize replay.

### Fixed
- Fresh background workspaces now surface pane output reliably when PTY control activity coincides with process output. (#2449)
- `herdr config check` now reports unknown built-in theme names instead of silently accepting them. (#2452)
- macOS `herdr --remote` clients now keep the accepted bridge socket blocking, preventing an immediate disconnect after the protocol handshake. (#2478, thanks @mathijshenquet)
- Prefix keybindings now preserve Shift in WezTerm Kitty keyboard mode, so commands such as config reload no longer trigger their unshifted action. (#2435)
Expand Down
79 changes: 62 additions & 17 deletions src/pty/actor/unix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -464,22 +464,9 @@ impl PtyIoActorRunner {
ACTOR_IDLE_POLL_MS,
) {
Ok(readiness) => {
if readiness.wake_ready {
if let Err(err) = fd::drain_wake_fd(self.wake_read_fd.as_raw_fd()) {
debug!(pane = self.pane_id, err = %err, "PTY actor wake drain failed");
break;
}
continue;
}
if self.state == ActorState::Running
&& readiness.pty_read_ready
&& !self.read_once()
{
if !self.handle_poll_readiness(readiness) {
break;
}
if readiness.pty_write_ready && !self.pending_writes.is_empty() {
self.flush_pending_writes_once();
}
}
Err(err) => {
debug!(pane = self.pane_id, err = %err, "PTY actor poll failed");
Expand All @@ -494,6 +481,22 @@ impl PtyIoActorRunner {
debug!(pane = self.pane_id, "PTY actor exiting");
}

fn handle_poll_readiness(&mut self, readiness: fd::PtyWakeReadiness) -> bool {
if readiness.wake_ready {
if let Err(err) = fd::drain_wake_fd(self.wake_read_fd.as_raw_fd()) {
debug!(pane = self.pane_id, err = %err, "PTY actor wake drain failed");
return false;
}
}
if self.state == ActorState::Running && readiness.pty_read_ready && !self.read_once() {
return false;
}
if readiness.pty_write_ready && !self.pending_writes.is_empty() {
self.flush_pending_writes_once();
}
true
}

fn drain_commands(&mut self) -> bool {
if self.drain_control_commands() {
return true;
Expand Down Expand Up @@ -862,7 +865,7 @@ mod tests {
(handle, peer, read_rx)
}

fn actor_runner_for_unit_test() -> (PtyIoActorRunner, UnixStream) {
fn actor_runner_for_unit_test() -> (PtyIoActorRunner, UnixStream, fd::WakeWriter) {
let (actor_socket, peer) = UnixStream::pair().expect("socket pair");
actor_socket
.set_nonblocking(true)
Expand All @@ -871,6 +874,7 @@ mod tests {
let (_data_tx, data_rx) = mpsc::channel(ACTOR_COMMAND_BUFFER);
let (_control_tx, control_rx) = std_mpsc::channel();
let wake_pipe = fd::create_wake_pipe().expect("wake pipe");
let wake = wake_pipe.writer;
let runner = PtyIoActorRunner {
pane_id: 1,
file: std::fs::File::from(owned),
Expand All @@ -886,18 +890,59 @@ mod tests {
on_reader_exit: None,
poll_observer: None,
};
(runner, peer)
(runner, peer, wake)
}

#[test]
fn actor_ignores_empty_user_input_write() {
let (mut runner, _peer) = actor_runner_for_unit_test();
let (mut runner, _peer, _wake) = actor_runner_for_unit_test();

assert!(!runner.handle_data_command(PtyIoDataCommand::WriteUserInput(Bytes::new())));

assert!(runner.pending_writes.is_empty());
}

#[test]
fn actor_processes_pty_io_when_wake_is_also_ready() {
let (mut runner, mut peer, wake) = actor_runner_for_unit_test();
peer.set_read_timeout(Some(Duration::from_secs(1)))
.expect("peer timeout");
let (read_tx, read_rx) = std_mpsc::channel();
runner.on_read = Box::new(move |bytes| {
read_tx
.send(Bytes::copy_from_slice(bytes))
.expect("read callback receiver alive");
PtyReadResult::empty()
});

peer.write_all(b"simultaneous-output")
.expect("peer writes output");
runner.enqueue_write(Bytes::from_static(b"simultaneous-input"));
wake.wake().expect("wake actor");
let readiness = fd::poll_pty_and_wake(
runner.file.as_raw_fd(),
runner.wake_read_fd.as_raw_fd(),
true,
true,
100,
)
.expect("poll succeeds");
assert!(readiness.wake_ready);
assert!(readiness.pty_read_ready);
assert!(readiness.pty_write_ready);

assert!(runner.handle_poll_readiness(readiness));
assert_eq!(
read_rx
.recv_timeout(Duration::from_secs(1))
.expect("PTY read"),
Bytes::from_static(b"simultaneous-output")
);
let mut input = [0; 18];
peer.read_exact(&mut input).expect("peer receives input");
assert_eq!(&input, b"simultaneous-input");
}

#[test]
fn actor_writes_user_input_to_owned_fd() {
let (handle, mut peer, _read_rx) = actor_with_socket_pair(false);
Expand Down
Loading