feat(detect): add muse agent with generic Pick blocked detection - #2489
feat(detect): add muse agent with generic Pick blocked detection#2489ohk wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds Muse as a supported agent. The change defines Muse aliases and executable mappings, adds bundled and website detection manifests for terminal states, and adds Muse sound override configuration. ChangesMuse detection integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant DetectionEngine
participant MuseManifest
participant TerminalPane
DetectionEngine->>MuseManifest: evaluate Muse detection rules
MuseManifest->>TerminalPane: inspect aliases and terminal evidence
TerminalPane-->>MuseManifest: provide blocked, working, or idle evidence
MuseManifest-->>DetectionEngine: return Muse state
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @ohk, thanks for your interest in contributing. Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in The pull request author is not an approved contributor. If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents. Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written. If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 79b2bc5b-5e09-4326-8058-6f7f02062b92
📒 Files selected for processing (6)
src/config/sound.rssrc/detect/manifest.rssrc/detect/manifests/muse.tomlsrc/detect/mod.rswebsite/agent-detection/index.tomlwebsite/agent-detection/muse.toml
Greptile SummaryAdds Muse as a recognized agent with bundled and remotely published screen-detection rules, executable aliases, and per-agent sound configuration.
Confidence Score: 4/5The PR does not appear safe to merge until Muse working detection stops being suppressed by stale picker text in the wider working-rule region. The working rule still rejects Files Needing Attention: src/detect/manifests/muse.toml and website/agent-detection/muse.toml
|
| Filename | Overview |
|---|---|
| src/detect/mod.rs | Registers Muse throughout agent identification and replaces broad prefix recognition with exact executable aliases. |
| src/detect/manifests/muse.toml | Defines Muse state-detection rules for picker prompts, approvals, active work, and idle chrome. |
| website/agent-detection/muse.toml | Publishes a synchronized copy of the new Muse detection manifest. |
| src/config/sound.rs | Adds a default-enabled Muse entry to per-agent sound overrides. |
| src/detect/manifest.rs | Includes the Muse manifest in the bundled manifest registry. |
| website/agent-detection/index.toml | Adds Muse to the remotely published agent-manifest catalog. |
Reviews (2): Last reviewed commit: "fix(detect): tighten muse manifest and a..." | Re-trigger Greptile
Add Muse agent manifests and runtime detection for idle/working/blocked states. Blocked Pick is generic on footer 'Enter to select' so any question title/message triggers, fixing missed waiting answer where previous AND-gated rule required specific hint combos. Cover process names muse, muse-bin, muse-code variants and YOLO footer. refs #herdr
- manifests: change working_esc_interrupt and blocked_approval
from whole_recent to bottom_non_empty_lines(8) to use captured
bottom-buffer controls instead of incidental whole-pane text
- manifests: anchor idle_prompt line_regex to ^\s*⟩\s*$ so working
chrome "⟩ ..." does not match idle
- runtime: restrict muse lookup to explicit aliases
(muse|muse-bin|muse-code|muse-cli), remove starts_with("muse")
fallback that misclassified museum/muse-helper/muser; add
positive/negative identification tests
- keep website mirror identical; verified with agent_detection
manifest check --require-website
refs herdrdev#2489
refs herdrdev#2456
ef121fd to
4320fe1
Compare
Add Muse agent detection.
Evidence: herdr pane read --source detection (muse-spark-1.2-contributor 0.1.0) – idle YOLO/⟩, working esc to interrupt.
Replaces #2456 (closed by bot) with sidebar revert (6 files).