feat: support all agent integrations on windows - #2496
Merged
Conversation
kangal-bot
added
the
ai-review
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughNative Windows support was added for Devin, Hermes, Cursor, MastraCode, and Grok. The changes add PowerShell hooks, platform-specific commands and executables, Hermes path resolution, subprocess reporting, detection updates, tests, and documentation. ChangesNative Windows integrations
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant AgentCLI
participant PowerShellHook
participant HerdrCLI
participant PaneState
AgentCLI->>PowerShellHook: send session event JSON
PowerShellHook->>HerdrCLI: report-agent-session with session metadata
HerdrCLI->>PaneState: update active pane session
PowerShellHook-->>AgentCLI: emit empty JSON response
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 1698632b-c7e9-4519-a4d5-f8849f5b88e9
📒 Files selected for processing (17)
docs/next/CHANGELOG.mddocs/next/website/src/content/docs/integrations.mdxdocs/next/website/src/content/docs/ja/integrations.mdxdocs/next/website/src/content/docs/zh-cn/integrations.mdxscripts/test_hermes_integration_asset.pysrc/agent_resume.rssrc/detect/mod.rssrc/integration/assets/cursor/herdr-agent-state.ps1src/integration/assets/devin/herdr-agent-state.ps1src/integration/assets/grok/herdr-agent-state.ps1src/integration/assets/hermes/__init__.pysrc/integration/assets/mastracode/herdr-agent-state.ps1src/integration/env.rssrc/integration/mod.rssrc/integration/registry.rssrc/integration/targets.rssrc/integration/tests.rs
ogulcancelik
force-pushed
the
feature/windows-integrations
branch
from
August 7, 2026 19:42
4e54e2f to
29eeeff
Compare
Greptile SummaryThe PR adds native Windows support for Cursor, Devin, Grok, MastraCode, and Hermes integrations.
Confidence Score: 5/5The PR appears safe to merge. The previously reported Hermes upgrade issue is fixed because both the installed asset marker and the integration registry constant are now version 5, so existing version 4 installations are classified as outdated; no blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/integration/assets/hermes/init.py | Replaces Unix-socket session reporting with a cross-platform argv-based Herdr CLI invocation and correctly advances the asset marker to version 5. |
| src/integration/mod.rs | Selects platform-specific integration assets and advances the Hermes registry version to 5, matching the installed asset. |
| src/integration/targets.rs | Generates platform-appropriate hook commands for Cursor, MastraCode, and Grok. |
| src/integration/env.rs | Injects the current Herdr executable path into panes and resolves the platform-specific Hermes home directory. |
| src/integration/registry.rs | Enables the new Windows integration targets and aligns Hermes availability detection with its resolved home directory. |
| src/integration/tests.rs | Updates integration coverage for Windows support, command generation, installation, and availability. |
| src/agent_resume.rs | Uses Cursor's unambiguous Windows command launcher when restoring sessions. |
| src/detect/mod.rs | Uses the Windows Cursor launcher and recognizes node-wrapped MastraCode processes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Pane[Herdr-managed pane] --> Env[Injected pane environment]
Env --> Agent[Agent CLI]
Agent --> Hook[Installed PowerShell or Python hook]
Hook --> CLI[Herdr reporting CLI]
CLI --> Server[Herdr server]
Server --> State[Pane agent session/state]
Reviews (2): Last reviewed commit: "feat: support all agent integrations on ..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
ogulcancelik
force-pushed
the
feature/windows-integrations
branch
from
August 7, 2026 19:51
29eeeff to
0fce2c8
Compare
kangal-bot
removed
the
ai-review
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cursor-agent.cmdlauncher and make Hermes session reporting cross-platformValidation
just checkDevin was installed on the Windows VM, but its authenticated agent smoke test requires a Devin login.