Skip to content

fix(input): preserve alt-prefixed control keys - #2543

Merged
ogulcancelik merged 1 commit into
masterfrom
issue/2514-fish-alt-bindings
Aug 9, 2026
Merged

fix(input): preserve alt-prefixed control keys#2543
ogulcancelik merged 1 commit into
masterfrom
issue/2514-fish-alt-bindings

Conversation

@ogulcancelik

Copy link
Copy Markdown
Collaborator

Summary

  • decode an Alt-prefixed legacy byte by composing Alt with the inner legacy key
  • preserve Ctrl+Alt+F through Kitty-enabled panes as CSI 102;7u
  • add parser roundtrip and raw-input-to-pane regression coverage

Validation

  • just check

Refs #2514

@kangal-bot kangal-bot added the ai-review Trigger automated AI reviews for pull requests admitted by the PR gate label Aug 9, 2026
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f57bba0-cde4-494d-bf1e-ae17e6c884c0

📥 Commits

Reviewing files that changed from the base of the PR and between 2baebb5 and 5924f9e.

📒 Files selected for processing (3)
  • docs/next/CHANGELOG.md
  • src/input/parse.rs
  • src/pane/terminal.rs

📝 Walkthrough

Walkthrough

The input parser now preserves CONTROL and SHIFT when decoding legacy Alt-prefixed sequences. Regression tests cover round-trip parsing and Kitty pane encoding for Ctrl-Alt-F. The changelog records restored Fish keybinding support.

Changes

Ctrl-Alt key handling

Layer / File(s) Summary
Legacy modifier parsing
src/input/parse.rs
Legacy Alt-prefixed characters now reuse legacy parsing and add ALT to existing modifiers. Tests verify Ctrl-Alt-F parsing and byte round-tripping.
Kitty pane encoding
src/pane/terminal.rs, docs/next/CHANGELOG.md
Pane encoding now has coverage for the ESC [102;7u Ctrl-Alt-F sequence. The changelog records restored Fish Ctrl-Alt keybinding support.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: preserving Alt-prefixed control keys during input parsing.
Description check ✅ Passed The description directly explains the input fix, Kitty pane behavior, regression coverage, and validation command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/2514-fish-alt-bindings

Comment @coderabbitai help to get the list of available commands.

@ogulcancelik
ogulcancelik merged commit d277d2f into master Aug 9, 2026
7 checks passed
@kangal-bot kangal-bot removed the ai-review Trigger automated AI reviews for pull requests admitted by the PR gate label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants