Skip to content

perf(virtqueue/packed): Don't box transfer tokens #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

Gelbpunkt
Copy link
Member

This gets rid of the last talc allocation calls from receive_packet in netbench, everything else is now either on the stack or allocated with DeviceAlloc.

I haven't been able to measure a reliable improvement, but it should strictly be an improvement.

@mkroening mkroening self-assigned this Jun 2, 2025
@mkroening mkroening self-requested a review June 2, 2025 12:59
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mkroening mkroening added this pull request to the merge queue Jun 5, 2025
Merged via the queue into hermit-os:main with commit c3c0e60 Jun 5, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants