修复异步生图完成后错误刷新当前节点参数的问题(fix: prevent async generation from refreshing active nodes) - #178
Open
Rayen21 wants to merge 2 commits into
Open
修复异步生图完成后错误刷新当前节点参数的问题(fix: prevent async generation from refreshing active nodes)#178Rayen21 wants to merge 2 commits into
Rayen21 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题描述
当一个生图节点正在运行时,如果用户选中画布中的其他节点,前一个生图任务完成后,当前选中的节点会被错误地刷新为前一个生图节点的参数。
可能被覆盖的内容包括:
这会导致用户正在查看或编辑的节点参数被后台任务意外修改。
修复内容
预期效果
例如:
验证
已通过以下检查:
node --check static/js/smart-canvas.jsgit diff --checkSummary
Fixes an issue where an asynchronous image generation task could overwrite the settings of another node selected while the task was still running.
Problem
When one generation node was running, selecting another existing or newly created node could cause the completed generation task to refresh the selected node with the previous task's settings, including:
This happened because the async completion path relied on the globally selected node and mutable global settings.
Changes
Validation
node --check static/js/smart-canvas.jsgit diff --checkThis PR only contains the node-refresh bug fix and does not include the Draw Things gRPCServerCLI changes.