Limit Node.js version resolved when a wide range is used #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Node.js version resolver with the following features: - detect when a wide version range is in use - limit the resolved version to the latest LTS unless a higher version is explicitly requested - output the resolved data as JSON so that it's easier to understand
This is a sanity check since rebuilding the binary after making changes is a manual process. This will ensure that the binary can't be updated if there are failing tests.
The install process is updated to: - read the new JSON output from the Node.js version resolver binary - emit a warning if a wide version range is used - emit a warning if the LTS version limit had to be enforced
Signed-off-by: Colin Casey <[email protected]>
schneems
approved these changes
Nov 20, 2025
Contributor
schneems
left a comment
schneems
left a comment
There was a problem hiding this comment.
Made some suggestions, see comments.
Signed-off-by: Colin Casey <[email protected]>
Contributor
Author
|
@schneems addressed your feedback and added a |
* main: Prepare release v320 (#1517) Update default Node.js version to 24.x (#1510) Bump the github-actions group with 2 updates (#1513) Bump actions/checkout from 5 to 6 (#1514) Bump the rust-dependencies group in /resolve-version with 2 updates (#1515) Use buildpack banner from `heroku/buildpacks` (#1516) Prepare release v319 (#1512) Update Inventory for heroku/nodejs-engine (#1511) # Conflicts: # lib/binaries.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Node.js version resolver with the following features:
This allows the buildpack to output:
W-20075501