deps: resolve npm audit vulnerabilities and update CI configs#297
Merged
Conversation
Fixes 8 npm audit vulnerabilities (2 low, 6 moderate): - Apply npm audit fix for transitive deps (brace-expansion, fast-xml-parser, @aws-sdk/xml-builder). - Override diff to ^8.0.3 to patch mocha's vulnerable transitive jsdiff DoS. - Override uuid to ^11.1.1 to patch @heroku-cli/command's vulnerable transitive uuid bounds-check, avoiding a disruptive @heroku-cli/command 11→12 (with @oclif/core 2→4) major upgrade. Also updates dependabot.yml and release-please-config.json to align commit-message prefixes with conventional changelog sections.
Apply the same changelog-sections block to release-please-config.beta.json so beta and main releases categorize commits identically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 8 npm audit vulnerabilities (2 low, 6 moderate) — final state:
found 0 vulnerabilities. Also updatesdependabot.ymlandrelease-please-config.jsonto align commit-message prefixes (deps,deps(dev)) with conventional changelog sections.brace-expansion,fast-xml-parser,@aws-sdk/xml-buildernpm audit fix(lockfile only)mocha→diff@7.0.0diff: ^8.0.3override@heroku-cli/command@11→uuid@8.3.2uuid: ^11.1.1overrideThe
uuidoverride was chosen overnpm audit fix --force, which would have bumped@heroku-cli/command11→12 and pulled@oclif/core2→4 — a substantial breaking change touching every command file. Patchinguuiddirectly resolves the CVE without that churn. The major upgrade can be a separate effort if desired.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes: Local verification confirms 0 vulnerabilities and a passing test suite. Passing CI suffices for further validation.
Steps:
npm install— installs cleanly with overrides applied.npm audit— reportsfound 0 vulnerabilities.npm test— 192 passing.npm run build— completes successfully.Screenshots (if applicable)
Related Issues
GitHub issue: #[GitHub issue number]
GUS work item: [WI number](WI link)