feat(studio): timeline comments with agent resolution#936
Open
virang-nimrobo wants to merge 2 commits into
Open
feat(studio): timeline comments with agent resolution#936virang-nimrobo wants to merge 2 commits into
virang-nimrobo wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Successful timeline-comment agent runs were reported as "Stopped." The agent signals completion by removing its comment marker, which useTimelineComments detected and handled by aborting the fetch via cancel() — indistinguishable from a user cancel in the controller's abort branch. - Add agentRunController.complete(): aborts the run like cancel() but marks intent so the abort branch resolves to "Done." not "Stopped." - Use complete() for the marker-gone completion signal. - cancelAgentRun now always POSTs /agent/cancel (the server cancels by commentId regardless of owner) so a run reattached from a previous page load can be stopped; its stale local status is cleared. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds source-backed timeline comments in Studio, addressing #749 — Studio
previously had no durable way to leave timeline-specific edit requests and hand
them off to a coding agent.
studio-apiroute(
packages/core/src/studio-api/routes/timelineComments.ts) and helpers.TimelineCommentsTray.tsx) with timeline markers on theruler/canvas, plus comment authoring from the
EditModal.for resolution, with an
agentRunControllerthat manages run lifecycle.resolve to "Done." rather than "Stopped." (the agent signals completion by
removing its comment marker).
Changes
packages/core—timelineCommentsroute + helpers, wired intocreateStudioApi.packages/studio— comments tray, agent run controller,useTimelineCommentshook, and timeline/ruler/canvas marker integration.
Closes #749