code polish (apache#633)

* code polish * Update maven-on-ubuntu.yml * update mvnw * Revert "update mvnw" This reverts commit f43e2c4. * executable Co-authored-by: zhuanghaochao <[email protected]>
hhj0719 · Dec 9, 2020 · 872c5f4 · 872c5f4
1 parent c1e06cb
commit 872c5f4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 19 deletions.
diff --git a/.github/workflows/maven-on-macos.yml b/.github/workflows/maven-on-macos.yml
@@ -37,13 +37,10 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-maven-
       - uses: actions/checkout@v2
-      - name: checkout submodules
-        shell: bash
-        run: |
-          git submodule sync --recursive
-          git -c protocol.version=2 submodule update --init --force --recursive --depth=1
+        with:
+          submodules: true
       - uses: actions/setup-java@v1
         with:
           java-version: 8
       - name: Build with Maven
-        run: mvn -B clean install -Dmaven.javadoc.skip=true
+        run: ./mvnw -B clean -Dmaven.javadoc.skip=true install
diff --git a/.github/workflows/maven-on-ubuntu.yml b/.github/workflows/maven-on-ubuntu.yml
@@ -37,15 +37,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-maven-
       - uses: actions/checkout@v2
-      - name: checkout submodules
-        shell: bash
-        run: |
-          git submodule sync --recursive
-          git -c protocol.version=2 submodule update --init --force --recursive --depth=1
+        with:
+          submodules: true
       - uses: actions/setup-java@v1
         with:
           java-version: 8
       - name: Build with Maven
-        run: sudo mvn --batch-mode --no-transfer-progress clean install -Dmaven.javadoc.skip=true
-
+        run: ./mvnw -B clean -Dmaven.javadoc.skip=true install
       - uses: codecov/codecov-action@v1
diff --git a/.github/workflows/maven-on-windows.yml b/.github/workflows/maven-on-windows.yml
@@ -37,13 +37,10 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-maven-
       - uses: actions/checkout@v2
-      - name: checkout submodules
-        shell: bash
-        run: |
-          git submodule sync --recursive
-          git -c protocol.version=2 submodule update --init --force --recursive --depth=1
+        with:
+          submodules: true
       - uses: actions/setup-java@v1
         with:
           java-version: 8
       - name: Build with Maven
-        run: ./mvnw -B clean install -D"maven.javadoc.skip"=true
+        run: ./mvnw -B clean -D"maven.javadoc.skip"=true install
diff --git a/mvnw b/mvnw