-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: concurrency control queue #879
base: master
Are you sure you want to change the base?
feat: concurrency control queue #879
Conversation
d3d176b
to
10d5298
Compare
10d5298
to
56bf84c
Compare
@kanzihuang I assume this is still a WIP because I don't see the queue concurrency value being used in the processor/semaphore. I assume that is the end goal? |
@kamikazechaser - Hi! Reviewing the code, I think it does work as intended - instead of modifying the way the processor or semaphore work (which would affect only that specific Server), it uses the number of currently-being-processed tasks by checking its cardinality compared to the maximum concurrency for that queue. If you are looking for a different solution I'd be happy to take a look at it - I'd love for the dynamic queues work to make it in :) |
I think setting the maximum concurrency for different queues is reasonable, as not all queues have the same scenario and processing time. I hope to merge the PRs as soon as possible. Thank you very much. |
@kamikazechaser This is not a WIP. Here is the test code: The following is the specific implementation code: |
No description provided.