Fix check for other peers ahead and node stalled. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Could I have improved this further? The call to api.rpc.system.peers() downloads quite a lot of data we don't need. Is there a way to request just part of the returned data structure, or do we have to have it all? |
Author
|
Just notice that the last block number isn't being saved to the tmp file. |
Author
|
In fact, not a bug. It only writes to the file when it's behind peers, and this didn't occur on my test machine. |
Contributor
Unfortunately I think this is the only call that returns the peers' block number. I don't believe you can do a partial request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.