feat(remote-config): make sure relay, mirror node, explorers and block nodes can be deployed multiple times #2009

instamenta · 2025-05-23T13:29:21Z

Description

Related Issues

Closes #
Related to #

Pull request (PR) checklist

This PR added tests (unit, integration, and/or end-to-end)
This PR updated documentation
This PR added no TODOs or commented out code
This PR has no breaking changes
Any technical debt has been documented as a separate issue and linked to this PR
Any package.json changes have been explained to and approved by a repository manager
All related issues have been linked to this PR
All changes in this PR are included in the description
When this PR merges the commits will be squashed and the title will be used as the commit message, the 'commit message guidelines' below have been followed

Testing

This PR added unit tests
This PR added integration/end-to-end tests
These changes required manual testing that is documented below
Anything not tested is documented

The following manual testing was done:

TBD

The following was not tested:

TBD

Commit message guidelines

We use 'Conventional Commits' to ensure that our commit messages are easy to read, follow a consistent format, and for automated release note generation. Please follow the guidelines below when writing your commit messages:

BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type. NOTE: currently breaking changes will only bump the MAJOR version.
The title is prefixed with one of the following:

Prefix	Description	Semantic Version Update	Captured in Release Notes
feat:	a new feature	MINOR	Yes
fix:	a bug fix	PATCH	Yes
perf:	performance	PATCH	Yes
refactor:	code change that isn't feature or fix	none	No
test:	adding missing tests	none	No
docs:	changes to documentation	none	Yes
build:	changes to build process	none	No
ci:	changes to CI configuration	none	No
style:	formatting, missing semi-colons, etc	none	No
chore:	updating grunt tasks etc; no production code change	none	No

Signed-off-by: Zhan Milenkov <[email protected]>

…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components # Conflicts: # src/core/config/remote/components/consensus-node-component.ts # src/core/config/remote/components/relay-component.ts # src/core/config/remote/remote-config-manager.ts

Signed-off-by: Zhan Milenkov <[email protected]>

…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components

Signed-off-by: Zhan Milenkov <[email protected]>

…ross commands' Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

… on RelayComponent to consensusNodeIds, removed nodeStates on ConsensusNodeComponent Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…equivalents Signed-off-by: Zhan Milenkov <[email protected]>

…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components

Signed-off-by: Zhan Milenkov <[email protected]>

…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components # Conflicts: # src/commands/explorer.ts # src/commands/mirror-node.ts # src/commands/network.ts # src/commands/relay.ts # src/core/config/remote/types.ts # test/unit/commands/network.test.ts

Signed-off-by: Zhan Milenkov <[email protected]>

…e models Signed-off-by: Zhan Milenkov <[email protected]>

…ion layer related to the remote config Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…-mirror-node-explorer-and-block-nodes-can-be-deployed-multiple-times

Signed-off-by: Zhan Milenkov <[email protected]>

… logic for chart manager's isChartInstalled method Signed-off-by: Zhan Milenkov <[email protected]>

Signed-off-by: Zhan Milenkov <[email protected]>

…-mirror-node-explorer-and-block-nodes-can-be-deployed-multiple-times

Signed-off-by: Zhan Milenkov <[email protected]>

jeromy-cannon · 2025-05-30T17:59:16Z

.github/workflows/script/launch_network.sh

-npm run solo-test -- explorer destroy --deployment "${SOLO_DEPLOYMENT}" --force
-npm run solo-test -- relay destroy -i node1,node2 --deployment "${SOLO_DEPLOYMENT}" --cluster-ref kind-${SOLO_CLUSTER_NAME}
-npm run solo-test -- mirror-node destroy --deployment "${SOLO_DEPLOYMENT}" --force
+npm run solo-test -- explorer destroy --id 1 --deployment "${SOLO_DEPLOYMENT}" --force


for adding these IDs, I think if there is only one of them, they shouldn't have to specify which one to delete. This way it will be backwards compatible.

jeromy-cannon · 2025-05-30T18:04:11Z

src/data/schema/model/remote/state/component-ids-shema.ts

src/data/schema/model/remote/state/component-ids-shema.ts
misspelled schema

jeromy-cannon · 2025-05-30T18:04:23Z

src/data/schema/model/remote/state/component-ids-shema.ts

+import {Exclude, Expose} from 'class-transformer';
+
+@Exclude()
+export class ComponentIdsShema {


Suggested change

export class ComponentIdsShema {

export class ComponentIdsSchema {

jeromy-cannon · 2025-05-30T18:11:27Z

src/data/schema/model/remote/state/component-ids-shema.ts

I don't think this class is needed. I see that we already have a id inside of ComponentStateMetadataSchema. I think we talked about when deleting components to leave the component within the remote config (or did we get rid of that idea to not keep unused objects around? I don't see a deleted or similar in the DeploymentPhase...).

we got rid of soft delete

jeromy-cannon · 2025-05-30T18:41:45Z

src/core/config/remote/component-factory.ts

-    );
-
-    return new HAProxyStateSchema(metadata);
+    return new HAProxyStateSchema(this.getMetadata(ComponentTypes.HaProxy, clusterReference, namespace));


Suggested change

return new HAProxyStateSchema(this.getMetadata(ComponentTypes.HaProxy, clusterReference, namespace));

return new HaProxyStateSchema(this.getMetadata(ComponentTypes.HaProxy, clusterReference, namespace));

jeromy-cannon · 2025-05-30T18:44:52Z

src/core/config/remote/api/components-data-wrapper-api.ts

@@ -5,6 +5,7 @@ import {type ComponentTypes} from '../enumerations/component-types.js';
 import {type DeploymentPhase} from '../../../../data/schema/model/remote/deployment-phase.js';
 import {type ClusterReference, type ComponentId} from '../../../../types/index.js';
 import {type DeploymentStateSchema} from '../../../../data/schema/model/remote/deployment-state-schema.js';
+import {type ComponentIdsShema} from '../../../../data/schema/model/remote/state/component-ids-shema.js';


the only place in the business layer that should reference or have access to the data layer schemas is the runtime state. the runtime state should transfer the schema contents into a business layer object and also handle converting the business layer object into a schema object. the schema objects are really only for reading and writing (and migrating)

jeromy-cannon · 2025-05-30T19:07:34Z

src/commands/relay.ts

+        const secrets: {
+          data: Record<string, string>;
+          name: string;
+          namespace: string;
+          type: string;
+          labels: Record<string, string>;


we should create a src/integration/kube/resources/secret/secret.ts, it was missed during our creation of the kube rewrite.

jeromy-cannon · 2025-05-30T19:45:43Z

src/commands/flags.ts

+    constName: 'id',
+    name: 'id',
+    definition: {
+      describe: 'ID',


Suggested change

describe: 'ID',

describe: 'The numeric identifier for the component',

instamenta added 30 commits April 15, 2025 10:33

extracted most logic from other branch

e82d0ef

Signed-off-by: Zhan Milenkov <[email protected]>

changes from parent branch

fa7c866

Signed-off-by: Zhan Milenkov <[email protected]>

removing noise

f17cb00

Signed-off-by: Zhan Milenkov <[email protected]>

removing block-node related logic

80d1b2c

Signed-off-by: Zhan Milenkov <[email protected]>

removing block node logic

a441a79

Signed-off-by: Zhan Milenkov <[email protected]>

cleanup

3292683

Signed-off-by: Zhan Milenkov <[email protected]>

Merge remote-tracking branch 'origin/main' into 01822-refactor-remote…

d5e0f8f

…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components

removed state field from remote config components

04a98e0

Signed-off-by: Zhan Milenkov <[email protected]>

adjust tests

35cdc64

Signed-off-by: Zhan Milenkov <[email protected]>

changed disableComponent method with removeComponent and used it accc…

6caf9e2

…ross commands' Signed-off-by: Zhan Milenkov <[email protected]>

fix tests for ComponentsDataWrapper

41e392d

Signed-off-by: Zhan Milenkov <[email protected]>

added new field phase to all components, renamed consensusNodeAliases…

7ed7479

… on RelayComponent to consensusNodeIds, removed nodeStates on ConsensusNodeComponent Signed-off-by: Zhan Milenkov <[email protected]>

removed usages of ConsensusNodeStates

8e013ae

Signed-off-by: Zhan Milenkov <[email protected]>

switching from names on remote config components to ids

8115ba1

Signed-off-by: Zhan Milenkov <[email protected]>

replacing remote config component names with ids

c4c5914

Signed-off-by: Zhan Milenkov <[email protected]>

fixed all references to component name outside of tests

a5570dd

Signed-off-by: Zhan Milenkov <[email protected]>

removing usages of ComponentName and replacing them with ComponentId …

e4539b3

…equivalents Signed-off-by: Zhan Milenkov <[email protected]>

Merge remote-tracking branch 'origin/main' into 01822-refactor-remote…

e2177e3

…-config-logic-so-the-components-names-are-always-unique-change-logic-from-hard-delete-to-soft-delete-for-components

fixes

ba62c50

Signed-off-by: Zhan Milenkov <[email protected]>

fixed warnings from tests and polished implementation

630de7c

Signed-off-by: Zhan Milenkov <[email protected]>

lint-fix

6883f47

Signed-off-by: Zhan Milenkov <[email protected]>

fixed all unit tests

b7ceadd

Signed-off-by: Zhan Milenkov <[email protected]>

added TODO's linked to issues

1b44728

Signed-off-by: Zhan Milenkov <[email protected]>

fix e2e integration tests

a6f9ae3

Signed-off-by: Zhan Milenkov <[email protected]>

fix dual cluster setup test full

3788778

Signed-off-by: Zhan Milenkov <[email protected]>

fix tsc errros

2868bb9

Signed-off-by: Zhan Milenkov <[email protected]>

added types and changed 'name' proprety to 'id' on remote config stat…

577b10f

…e models Signed-off-by: Zhan Milenkov <[email protected]>

adding classes for the connection between the data runtime and execut…

3e61d46

…ion layer related to the remote config Signed-off-by: Zhan Milenkov <[email protected]>

instamenta added 21 commits May 30, 2025 09:32

adding support for legacy releaseNames

39995b4

Signed-off-by: Zhan Milenkov <[email protected]>

adding support foor legacy release names

92ff680

Signed-off-by: Zhan Milenkov <[email protected]>

adding support for legacy release names

7f2376a

Signed-off-by: Zhan Milenkov <[email protected]>

lint-fix

d5ae52d

Signed-off-by: Zhan Milenkov <[email protected]>

Merge remote-tracking branch 'origin/main' into 01823-make-sure-relay…

3a79b93

…-mirror-node-explorer-and-block-nodes-can-be-deployed-multiple-times

reverse obsolete changes

485a469

Signed-off-by: Zhan Milenkov <[email protected]>

add support for legacy release names for remote config validator, fix…

1e0965e

… logic for chart manager's isChartInstalled method Signed-off-by: Zhan Milenkov <[email protected]>

fix typescript errors

05240a4

Signed-off-by: Zhan Milenkov <[email protected]>

fix migration logic and mirror node remote config component creation

57f7429

Signed-off-by: Zhan Milenkov <[email protected]>

bump remote config version to 2

9429759

Signed-off-by: Zhan Milenkov <[email protected]>

fix dual cluster test and remote config migrations

086a970

Signed-off-by: Zhan Milenkov <[email protected]>

lint-fix

7d6a764

Signed-off-by: Zhan Milenkov <[email protected]>

add custom logic for legacy relay release name

ea9f878

Signed-off-by: Zhan Milenkov <[email protected]>

add debug log

06899c3

Signed-off-by: Zhan Milenkov <[email protected]>

fix migration

40e1801

Signed-off-by: Zhan Milenkov <[email protected]>

fix v2 migration

3c8088e

Signed-off-by: Zhan Milenkov <[email protected]>

fix explorer deployment

1d51b8b

Signed-off-by: Zhan Milenkov <[email protected]>

remove obsolete logic

ba80424

Signed-off-by: Zhan Milenkov <[email protected]>

add additional log

e962e1e

Signed-off-by: Zhan Milenkov <[email protected]>

Merge remote-tracking branch 'origin/main' into 01823-make-sure-relay…

ed51d8b

…-mirror-node-explorer-and-block-nodes-can-be-deployed-multiple-times

add id to 'destroy commands', fix migration logic for relay

8b06ac2

Signed-off-by: Zhan Milenkov <[email protected]>

instamenta marked this pull request as ready for review May 30, 2025 17:03

instamenta requested review from a team as code owners May 30, 2025 17:03

instamenta requested review from leninmehedy and JeffreyDallas May 30, 2025 17:03

fix migration

6fc675f

Signed-off-by: Zhan Milenkov <[email protected]>

jeromy-cannon reviewed May 30, 2025

View reviewed changes

jeromy-cannon added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label May 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(remote-config): make sure relay, mirror node, explorers and block nodes can be deployed multiple times #2009

feat(remote-config): make sure relay, mirror node, explorers and block nodes can be deployed multiple times #2009

Uh oh!

instamenta commented May 23, 2025 •

edited

Loading

Uh oh!

jeromy-cannon May 30, 2025

Uh oh!

jeromy-cannon May 30, 2025

Uh oh!

jeromy-cannon May 30, 2025

Uh oh!

jeromy-cannon May 30, 2025

Uh oh!

instamenta Jun 2, 2025

Uh oh!

jeromy-cannon May 30, 2025

Uh oh!

jeromy-cannon May 30, 2025

Uh oh!

jeromy-cannon May 30, 2025

Uh oh!

jeromy-cannon May 30, 2025

Uh oh!

Uh oh!

	export class ComponentIdsShema {
	export class ComponentIdsSchema {

	return new HAProxyStateSchema(this.getMetadata(ComponentTypes.HaProxy, clusterReference, namespace));
	return new HaProxyStateSchema(this.getMetadata(ComponentTypes.HaProxy, clusterReference, namespace));

	describe: 'ID',
	describe: 'The numeric identifier for the component',

feat(remote-config): make sure relay, mirror node, explorers and block nodes can be deployed multiple times #2009

Are you sure you want to change the base?

feat(remote-config): make sure relay, mirror node, explorers and block nodes can be deployed multiple times #2009

Uh oh!

Conversation

instamenta commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Pull request (PR) checklist

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

instamenta commented May 23, 2025 •

edited

Loading