Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module options for setting per-domain properties. #430

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

twoolie
Copy link
Contributor

@twoolie twoolie commented Mar 11, 2025

I've split the options from the previous version into two sets, globalOptions which contains options that can only be set in the [global] section, and domainOptions that can be set per-domain. These are merged together into the himmelblau.settings option which feeds the global section. A new option himmelblau.domains is added which takes an attribute set of domain names to configuration options for that domain, and these feed additional sections in the config file named for each domain.

Addititionally, I replaced the ugly string-concat config generation with nixpkgs' generators.toINI which means if a new option is added in the future, you won't have to touch the config generation code.

All previously working configurations should continue to work as before.

Additionally I made a small cleanup to the Makefile to factor out some commands, and keep named links to the different nix outputs.

@dmulder dmulder merged commit e333514 into himmelblau-idm:main Mar 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants