Add module options for setting per-domain properties. #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split the options from the previous version into two sets,
globalOptions
which contains options that can only be set in the[global]
section, anddomainOptions
that can be set per-domain. These are merged together into thehimmelblau.settings
option which feeds the global section. A new optionhimmelblau.domains
is added which takes an attribute set of domain names to configuration options for that domain, and these feed additional sections in the config file named for each domain.Addititionally, I replaced the ugly string-concat config generation with nixpkgs'
generators.toINI
which means if a new option is added in the future, you won't have to touch the config generation code.All previously working configurations should continue to work as before.
Additionally I made a small cleanup to the Makefile to factor out some commands, and keep named links to the different nix outputs.