-
Notifications
You must be signed in to change notification settings - Fork 57
add clarity formatter guide #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
copy tweaks
I made some copy edits to the guide. One overarching question i have is this section feels a bit out of place alongside the other Clarinet guides. The other guides teach devs how to do things, whereas this guide mostly explains formatting rules. I wonder if this should be broken apart in docs into 2 components:
|
i see the points here, i had thought about it - but it ultimately doesn't feel like it warrants splitting into two. if the guide feels too long or doesn't flow well that's one thing, but breaking it into two for something as simple/straightforward as a formatter just seems like overkill to me.
yeah i thought on this a bit as well, what i landed on re: Clarity section was that the formatter is a tool that helps developers work with Clarity code, and the Clarity section focuses more on the language itself (syntax, functions, best practices for writing Clarity code) so it felt like this belonged with the Clarinet section vs Clarity section. though i will say moving it outside of the Guides section on the sidebar and just as a standalone reference is the best solution, which is what i've done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a section explaining how to disable/enable Clarity LSP formatting in VSCode (maybe with a screenshot)
As well as how to enable/disable format on save for a given language in VSCode.
"[clarity]": {
"editor.formatOnSave": true,
},
I think it can be helpful for beginners
What does this PR do?
Add a guide going over the new Clarity formatter in vscode and clarinet.