[xpu] extend runs_on test markers to include xpu#10445
[xpu] extend runs_on test markers to include xpu#10445singhalshubham03 wants to merge 2 commits into
Conversation
Add "xpu" to @pytest.mark.runs_on across data-processor, data, e2e, and eval test suites so tests are picked up on Intel XPU CI targets. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
singhalshubham03
force-pushed
the
xpu-accelerate-configs-and-test-support
branch
from
8f37b58 to
c926777
Compare
singhalshubham03
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Intel XPU devices, specifically targeting fine-tuning of Llama-3.3-70B on 4x Intel Arc B60 GPUs. It adds various Accelerate and training configurations, a comprehensive README, and a launch script with optimized environment variables for XPU. Additionally, the test suite has been updated to include XPU in the supported execution environments. Feedback suggests improving the portability of the launch script by avoiding hardcoded virtual environment paths and making the WANDB integration configurable.
I am having trouble creating individual review comments. Click here to see my feedback.
examples/train_llama33_70b_4xpu/train.sh (19)
Hardcoding the virtual environment path 'venv_main_2.11' limits the portability of this script. Consider using an environment variable or a relative path that is more flexible.
examples/train_llama33_70b_4xpu/train.sh (44)
Disabling WANDB via an environment variable in the script is a good practice for reproducibility, but consider making this configurable via an environment variable to allow users to enable it if needed.
|
@hiyouga can you please review this PR |
3 participants
Summary
Add
"xpu"to@pytest.mark.runs_onacross all data-processor, data, e2e, and eval test suites so tests are picked up on Intel XPU CI targets.Files changed (14):
tests/data/processor/test_feedback.pytests/data/processor/test_pairwise.pytests/data/processor/test_processor_utils.pytests/data/processor/test_supervised.pytests/data/processor/test_unsupervised.pytests/data/test_collator.pytests/data/test_converter.pytests/data/test_formatter.pytests/data/test_loader.pytests/data/test_mm_plugin.pytests/data/test_template.pytests/e2e/test_chat.pytests/e2e/test_train.pytests/eval/test_eval_template.pyTest plan
pytest tests/ -m "runs_on" --device xpu🤖 Generated with Claude Code