Skip to content

docs: clarify reasoning-only template guidance#10574

Open
he-yufeng wants to merge 1 commit into
hiyouga:mainfrom
he-yufeng:fix/reasoning-nothink-guidance
Open

docs: clarify reasoning-only template guidance#10574
he-yufeng wants to merge 1 commit into
hiyouga:mainfrom
he-yufeng:fix/reasoning-nothink-guidance

Conversation

@he-yufeng

Copy link
Copy Markdown

Summary

  • clarify the reasoning-template warning so _nothink is recommended only when a non-reasoning template exists
  • document the reasoning-only path (template: qwen3_6 + enable_thinking: false) in both English and Chinese dataset READMEs
  • keep template behavior unchanged

Fixes #10566.

Tests

  • python -m py_compile src/llamafactory/data/template.py
  • python -m ruff check src/llamafactory/data/template.py
  • Select-String -Path data\README.md,data\README_zh.md,src\llamafactory\data\template.py -Pattern "qwen3_6|enable_thinking: false|qwen3_vl_nothink" -Encoding UTF8
  • git diff --check

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in both English and Chinese README files, as well as the warning message in template.py, to clarify the usage of reasoning templates. Specifically, it explains that the _nothink template suffix should only be used when a separate non-reasoning template is available, whereas for reasoning-only model families, users should keep the reasoning template and set enable_thinking: false to match non-thinking inference. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] Misleading _nothink suffix warning for reasoning-only model families (e.g. Qwen3.6)

1 participant