Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ipa support #132

Merged
merged 10 commits into from
Jun 25, 2024
Merged

Feature ipa support #132

merged 10 commits into from
Jun 25, 2024

Conversation

jkiddo
Copy link
Collaborator

@jkiddo jkiddo commented May 12, 2024

Original PR closed due to branch renaming. Continuing here from #76

@jkiddo jkiddo requested a review from jacand May 12, 2024 11:35
@jkiddo
Copy link
Collaborator Author

jkiddo commented May 12, 2024

I would like to suggest that we do sort of like what the Finnish affilate has done (see https://hl7.fi/fhir/). Make DK Core compliant profilewise but keep IPA security aspects in its own separate IG like https://hl7.fi/fhir/finnish-smart/

@jacand how does that sound to you?

This was referenced May 12, 2024
@jkiddo
Copy link
Collaborator Author

jkiddo commented May 13, 2024

That is also a good question for you @ovi-medcom & @christiangasser-lakeside 👆

@jacand
Copy link
Collaborator

jacand commented May 30, 2024

I would like to suggest that we do sort of like what the Finnish affilate has done (see https://hl7.fi/fhir/). Make DK Core compliant profilewise but keep IPA security aspects in its own separate IG like https://hl7.fi/fhir/finnish-smart/

@jacand how does that sound to you?

Sounds good - with the possible exception of DkCoreObservation, which we may have to split in two? IPAObservations always have Patients as subjects, while we decided to keep DkCoreObservation open to other classes of subjects. -- and there is no multiple inheritance. We need to discuss how to move this one forward...

@jkiddo
Copy link
Collaborator Author

jkiddo commented Jun 3, 2024

we should probably follow this as well: HL7/fhir-ig-publisher#884

@jkiddo
Copy link
Collaborator Author

jkiddo commented Jun 14, 2024

@jacand - I've introduced a new Observation profle - but maybe it isn't needed. That is still an open thing to consider. @tmsMedcom I think we should take up this PR for next available SIG meeting (and maybe retarget it to 3.3.0 branch).

@jkiddo jkiddo requested a review from tmsMedcom June 14, 2024 18:04
@jkiddo
Copy link
Collaborator Author

jkiddo commented Jun 14, 2024

The IPA minimum requirements are very reasonable and we can leave out the SMART part and isolate that in its own IG ( early draft is here: https://build.fhir.org/ig/jkiddo/dk-smart/branches/master/index.html )

@jkiddo
Copy link
Collaborator Author

jkiddo commented Jun 14, 2024

Which is comparable with the Finnish way

@jkiddo jkiddo changed the base branch from master to 3.3.0 June 18, 2024 06:56
@jkiddo jkiddo marked this pull request as ready for review June 25, 2024 18:40
# Conflicts:
#	input/fsh/DkCoreObservation.fsh
@jkiddo jkiddo merged commit b57f863 into 3.3.0 Jun 25, 2024
@jkiddo jkiddo deleted the feature-ipa-support branch June 25, 2024 21:11
jkiddo added a commit that referenced this pull request Feb 1, 2025
* Added Location and PractitionerRole

* fatfingered a '*'

* Moved NPU subset into its own Code System fragment.

* Remove special treatment of NPU

* Testing out fragments for NPU

* Adjusted unicodes

* Corrected descriptions

* Mapped "comments" using https://hl7.org/fhir/codesystem.html#defined-props

* Added correct property concept values

* Removed locale duplicate displays
Made SCT alias target DK by default

* Refined used of DK profiles

* indented properties

* Reintroduced special url for NPU to remove IGP error.

* Feature ipa support (#132)

* Introduced IPA support

* Update dep of IPA

* Adjusted to 1.0.0

* Removed merge files

* Added compliesWith and child profile for IPA compliance (#133)

* Changed to imposeProfile

* Update release-notes.md

* Update release-notes.md

* Added proper base definition

* Fix: Changed to assignment instead of declaration of imposeProfile

* Update DkCoreObservation.fsh

* Initial commit of ServiceRequest

* Update DkCoreServiceRequest.fsh

* Added content for ServiceRequest

* Update DkCoreServiceRequest.fsh

* Added ignores for NPU-errors

* Update name of profile and content of DkCoreServiceRequestCodes

* priority valueset, reasoncode and reason reference added to ServiceRequest

* changed slice name

* Update StructureDefinition-dk-core-servicerequest-intro.md

* Updated name of intro-file

* Update valueSets.fsh

* ServiceRequest coding updated in the profile, as well as in the documentation.

* ServiceRequest example corrected, documentation for priority and reasonCode added

* Updated scope and usage section according to #136

* Updated scope and usage section according to #135

* added to relationship value set and code system supplement to account for #135 and #134

* Handled issues from consultation

#140, #139, #137

* Update StructureDefinition-dk-core-patient-intro.md

#138

* Update DkCorePatient.fsh

#126

* Update DkCorePatient.fsh

#126

* Updated ServiceRequest ValueSet

* Updated scope and usage section according to #136

* Updated scope and usage section according to #135

* added to relationship value set and code system supplement to account for #135 and #134

* Update DkCorePatient.fsh

#126

* Fixed NPU error codes

* no message

* doc start on IPA inspired by fhir.fh

* Added parts of documentation

* Fixed note templates

* Disabling gh builds as they are not needed.
Added documentation

* Updated Continua/PHD examples to latest PHD release and fixed license-messages and other QA issues

* Fixed some obvious QA warnings: IPA patient and practitioner names should have a .text element and UCUM units with annotations should have the display value including the annotation

* Handled comments from review

* Updated reference to DkCorePractitionerRole

* Separated the IPA profiles into their own file

* Change listing of profiles

* Adjusted naming

* Fixed bugs

* A bit of layout changes

* Added kebab cased id's.

* Added textual descriptions to IPA profiles

* Fixed link

* Removed wrong valueset binding - #152
Created DK supplement for standard codesystem

* Removed QA error

* Update release-notes.md

* Update publication-request.json

* syntax ...

* Update codeSystems.fsh

* Correction to #152

* Removed QA errors

* removed IG version warning

* Fixed spelling error

---------

Co-authored-by: tmsMedcom <[email protected]>
Co-authored-by: kirstinerosenbeck <[email protected]>
Co-authored-by: Christian Gasser <[email protected]>
Co-authored-by: Jacob Andersen <[email protected]>
Co-authored-by: hagensen-software <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants