-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
override Tapestry.ZoneManager#processReply to work with Prototype 1.7 #23
override Tapestry.ZoneManager#processReply to work with Prototype 1.7 #23
Conversation
I'm afraid its trickier than that ... what you have will, I believe, add the core JavaScript stack to every page, regardless of whether it needs it or not. Some people really like to have at least the initial page free of JS to speed loading. |
Oh right, I didn't think of that. Do you already have specific plans on how to solve the compatibility issues? Maybe replace |
I've thought about it and with tapx-prototype as a temporary patch, this unwanted behavior (forces JS onto all pages) is acceptable. |
Another issue here is that the palette.js and tapestry-js-fixes.js files might be added too late. I'm about to commit another approach (overriding the core JS stack). |
Remember that all JS libraries load before anything much executes; On Thu, Apr 7, 2011 at 7:55 AM, jochenberger
Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to (971) 678-5210 |
Sure, but won't they be loaded/executed in the way they appear in the page? If a file that's loaded between tapestry.js and tapestry-fixes.js already executes ZoneManager#processReply, it will fail, won't it? |
There's no difference in effect between the two solutions, except that JavaScript is late bound. Even if some code created an instance of On Thu, Apr 7, 2011 at 11:15 PM, jochenberger
Howard M. Lewis Ship Creator of Apache Tapestry The source for Tapestry training, mentoring and support. Contact me to (971) 678-5210 |
No description provided.