Open
Conversation
manzt
force-pushed
the
manzt/tailwind2
branch
5 times, most recently
from
d80fb3a to
df08d1d
Compare
manzt
force-pushed
the
manzt/tailwind2
branch
from
df08d1d to
cd2f897
Compare
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meant to replace #199. I'd originally merged and then ran into issues with styles in Jupyter and reverted the changes. I need to find the time to dig into the build and make sure the CSS is produced correctly for different scenarios. The one nice thing about the CSS in JS from before is that it was fairly portable. With tailwind (or any custom CSS for that matter), we need to find a way to inject the styles ourself. I think ShadowDOM can help us here.