Skip to content

OME-Zarr HCS plates: Have acquisition menu also at plate level#315

Merged
manzt merged 3 commits intohms-dbmi:mainfrom
m-albert:acquisition_menu_at_plate_level
Jan 29, 2026
Merged

OME-Zarr HCS plates: Have acquisition menu also at plate level#315
manzt merged 3 commits intohms-dbmi:mainfrom
m-albert:acquisition_menu_at_plate_level

Conversation

@m-albert
Copy link
Contributor

@m-albert m-albert commented Jan 23, 2026

Hi, thanks again for this awesome viewer!

When visualizing OME-Zarr HCS plates I think it's super useful that an "acquisition menu" is shown. However I noticed that this is currently only the case for the well view and not at the level of the top level plate. Therefore this PR implements the acquisition menu also at the plate level.

image

Copilot AI review requested due to automatic review settings January 23, 2026 16:23
@dbmi-svc-checkmarx
Copy link

dbmi-svc-checkmarx commented Jan 23, 2026

Logo
Checkmarx One – Scan Summary & Detailsb2087aa9-0433-41df-ab1d-3d70696cb1ca

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds functional acquisition menu support at the plate level, enabling users to filter plate wells by acquisition ID through URL query parameters and preserving acquisition selection when navigating from plate to well views.

Changes:

  • Added acquisition ID parsing from URL query parameters at the plate level (similar to existing well-level support)
  • Refactored well image path resolution to collect acquisition IDs and select images based on the acquisition filter
  • Updated plate onClick handler to preserve acquisition parameter when opening wells in new windows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

m-albert and others added 2 commits January 23, 2026 17:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@m-albert m-albert changed the title Have functional acquisition menu also at plate level OME-Zarr HCS plates: Have acquisition menu also at plate level Jan 23, 2026
Copy link
Collaborator

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally with https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0001A/2551.zarr
Works fine for me 👍

@m-albert
Copy link
Contributor Author

Thank you so much for reviewing @will-moore ! And for adding an example dataset.

Copy link
Member

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@manzt manzt merged commit 4ea64c0 into hms-dbmi:main Jan 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants