Merged
Conversation
Contributor
noxxspring
commented
Feb 28, 2025
noxxspring
commented
Am0du
reviewed
Mar 1, 2025
| .authorizeHttpRequests(httpRequests -> | ||
| httpRequests | ||
| httpRequests.requestMatchers((WHITELIST)).permitAll() | ||
| .requestMatchers( |
Contributor
There was a problem hiding this comment.
Add other whitelisted endpoint to your Array to ensure consistency in the codebase
Contributor
There was a problem hiding this comment.
Use the error response in the codebase
| CallResponse response = twilioCallService.makeCall(callRequest); | ||
| return ResponseEntity.ok(response); // 200 OK | ||
| } catch (IllegalArgumentException e) { | ||
| return ResponseEntity.badRequest().body(new hng_java_boilerplate.twilio.CallLogs.ErrorResponse("Invalid request", e.getMessage())); // 400 Bad Request |
Contributor
There was a problem hiding this comment.
Errors are returned a certain way in the code base, review it
noxxspring
force-pushed
the
twilioServiceCall
branch
from
9708a7a to
1259365
Compare
Am0du
requested changes
Mar 2, 2025
Contributor
There was a problem hiding this comment.
There's a exception directory that manages exceptions, all you have to do is just throw the specified exception with a message..
Am0du
requested changes
Mar 2, 2025
Am0du
approved these changes
Mar 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.